fileio: use the prefixed lz4frame type LZ4F_contentChecksum_t
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 83/100
Research direction
Start in programs/fileio.c and inspect the LZ4_VERSION_NUMBER <= 10600 compatibility block and the checksum cast described in the issue. Update the obsolete enum usage and compatibility definition as suggested, then build zstd with lz4 support, including a build with -Werror. Done when supported lz4 versions compile without deprecated enum warnings.
Written by the indexing model from the issue text.
Description
programs/fileio.c defines LZ4F_ENABLE_OBSOLETE_ENUMS and employs contentChecksum_t, an unprefixed name obsolete since lz4 v1.7.0.
- lz4 v1.11.0 removed these names : zstd no longer builds with lz4 support (lz4/lz4#2046).
- lz4 v1.11.1 restores them (lz4/lz4#2053), but deprecated : a compilation warning, an error with
-Werror.
Suggested fix :
(LZ4F_contentChecksum_t)checksumFlag- drop
#define LZ4F_ENABLE_OBSOLETE_ENUMS - in the
LZ4_VERSION_NUMBER <= 10600block, add#define LZ4F_contentChecksum_t contentChecksum_t
- Dominant language
- C
- Stars
- 28.1k
- Forks
- 2.7k
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from facebook/zstd
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
ZSTD_decompressStream accepts a Compressed_Block with Block_Size 0 that ZSTD_decompress rejectsPossibly taken @Artyx71 claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
One-shot decoding refuses some skippable framesPossibly taken @ceedot-rock claimed this 4 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
`ZSTD_getDictID_fromFrame` returns a skippable frame's magic variant as its dictionary IDPossibly taken @b84330808 claimed this 13 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
cover.c does not build on OpenHarmony: qsort_r is exported but not declared (musl)Possibly taken @bfs2021 claimed this 14 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Similar issues
-
HTTP Request Smuggling: non-final chunked Transfer-Encoding not rejected (CWE-444)Possibly taken @code1a2024 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
jaredgei/wow-forever-android#97 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
openziti/ziti-sdk-c#1254 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
flatpak/xdg-desktop-portal#2215 ·
Maintainers usually reply within 2 days
-
http_fetch tests: the two no-child rows fail, not skip, where a task's children file does not existPossibly taken A pull request linked to this issue is open or already merged. Openarea:http kind:gate-defect
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
InauguralSystems/EigenScript#2397 ·
Maintainers usually reply within 1 day