TargetAutomation.IndividualSetting is not parsed correctly

Open
  • Is something wrong?
#489 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
api

Research direction

Start by tracing how SavedAudience.getFieldTargeting() parses Targeting.getFieldTargetingAutomation().getFieldIndividualSetting(), focusing on the Object value returned for geo. Reproduce the example against v22.0 or higher and verify that the resulting AdSet targeting sends {"geo":1} rather than {"geo":1.0} and is accepted.

Written by the indexing model from the issue text.

Description

When retrieving a SavedAudience in v22.0 or higher, the IndividualSetting field is an Object type and is not parsed correctly. Specifically, the geo field's value is parsed as 1.0 instead of 1. When this SavedAudience object is then used to create an AdSet, the request is rejected because the value is invalid.

This example:

final SavedAudience savedAudience = new SavedAudience(120218882502790414L, context).get().requestTargetingField().execute();
final Targeting fieldTargeting = savedAudience.getFieldTargeting();
final Object fieldIndividualSetting = fieldTargeting.getFieldTargetingAutomation().getFieldIndividualSetting();
System.out.println(fieldIndividualSetting);

outputs

{geo=1.0}

And when using that targeting field on an AdSet request:

AdAccount.APIRequestCreateAdSet adSetToCreate = adAccount.createAdSet()
                                                         .setName("adset")
                                                         ...
                                                         .setTargeting(fieldTargeting).execute()

The debug output shows that {geo=1.0} is being sent in the targeting parameter (this is from a request using a different saved audience but ends in the same result)

18:04:02.921 [main] INFO  c.s.p.m.api.MetaPostBoosterApi -- ========Start of API Call========
18:04:02.922 [main] INFO  c.s.p.m.api.MetaPostBoosterApi -- Post: https://graph.facebook.com/v23.0/act_213324006957203/adsets
...
18:04:02.922 [main] INFO  c.s.p.m.api.MetaPostBoosterApi -- Content-Disposition: form-data; name="targeting"
18:04:02.922 [main] INFO  c.s.p.m.api.MetaPostBoosterApi -- {"age_max":65,"age_min":18,"age_range":[18,65],"genders":[0],"geo_locations":{"cities":[{"country":"US","distance_unit":"mile","key":"2525495","name":"Austin","radius":25,"region":"Texas","region_id":"3886"},{"country":"US","distance_unit":"mile","key":"2526105","name":"Cedar Park","radius":25,"region":"Texas","region_id":"3886"},{"country":"US","distance_unit":"mile","key":"2527173","name":"Georgetown","radius":25,"region":"Texas","region_id":"3886"},{"country":"US","distance_unit":"mile","key":"2528026","name":"Lakeway","radius":25,"region":"Texas","region_id":"3886"},{"country":"US","distance_unit":"mile","key":"2528104","name":"Leander","radius":25,"region":"Texas","region_id":"3886"},{"country":"US","distance_unit":"mile","key":"2529681","name":"Round Rock","radius":25,"region":"Texas","region_id":"3886"},{"country":"US","distance_unit":"mile","key":"2530714","name":"West Lake Hills","radius":25,"region":"Texas","region_id":"3886"}],"location_types":["home","recent"]},"publisher_platforms":["facebook"],"targeting_automation":{"advantage_audience":1,"individual_setting":{"geo":1.0}}}

Manually changing the value to {"geo":1} gives a successful result.

Dominant language
Java
Stars
473
Forks
344
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from facebook/facebook-java-business-sdk

All issues in facebook/facebook-java-business-sdk

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.