Show severity as text instead of skin images
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
The icon lookup is in CheckstyleReportRenderer.iconSeverity, which returns the images/icon_*_sml.gif paths. Read how each severity call site prints the severity name beside the icon, then remove the image output so the text stands alone. Done when the rendered report contains no references to the icon files and every severity still appears as text, which the report renderer tests should confirm.
Written by the indexing model from the issue text.
Description
The Checkstyle report draws each severity with images/icon_info_sml.gif, icon_warning_sml.gif or icon_error_sml.gif (CheckstyleReportRenderer.iconSeverity). Those files belong to the site skin, not to the plugin, so a skin that does not ship them leaves broken images in the report. Every call already prints the severity name next to the image, so the image can go and the text can carry the severity on its own.
maven-project-info-reports-plugin (apache/maven-project-info-reports-plugin#688), maven-surefire (apache/maven-surefire#3565) and maven-changes-plugin (apache/maven-changes-plugin#685) made the same change. The Fluido skin can drop the icons once report plugins stop referencing them: apache/maven-fluido-skin#364.
- Dominant language
- Java
- Stars
- 98
- Forks
- 72
- Avg merge
- 8h 29m
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/maven-checkstyle-plugin
-
bug
Difficulty 3/5 Half a day Newbie friendliness 25/100
apache/maven-checkstyle-plugin#736 · 1 comment ·
Maintainers usually reply within 1 day
-
DefaultCheckstyleExecutor uses deprecated methodPossibly taken @efegokdemir claimed this 4 days ago. Openmaintenance
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
apache/maven-checkstyle-plugin#718 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 38/100
apache/maven-checkstyle-plugin#675 ·
Maintainers usually reply within 1 day
-
Update dependencies.May be free again A pull request for this issue was closed without being merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
apache/maven-checkstyle-plugin#664 ·
Maintainers usually reply within 1 day
-
DefaultCheckstyleExecutor should be a failure, not an errorPossibly taken @efegokdemir claimed this 40 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 58/100
apache/maven-checkstyle-plugin#656 · 1 comment ·
Maintainers usually reply within 1 day
All issues in apache/maven-checkstyle-plugin
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
a2aproject/a2a-java#1275 ·
Maintainers usually reply within 1 day
-
module/ftp Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ballerina-platform/ballerina-library#9476 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
HMCL-dev/HMCL#7175 · 1 reaction ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
anwilli5/coin-collection-android-US#515 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
FasterXML/jackson-databind#6398 ·
Maintainers usually reply within 1 day