Duplicated code
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 42/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- api
Research direction
Start by reading dom.js lines 27-56 and the linked duplication guidance. Refactor the duplicated code in that range without changing behavior; done means the repeated logic is consolidated and the existing behavior remains covered by the repository's tests.
Written by the indexing model from the issue text.
Description
See here: https://github.com/ryanmcdermott/clean-code-javascript#remove-duplicate-code for explanation on why it is bad to duplicate code.
The code here: https://github.com/fac-14/NDJS-API/blob/master/dom.js#L27-L56 has some dupliation and can be refactored.
(Sorry, I know you guys had a lot to do in a short period of time).
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fac-14/NDJS-API
-
README needs contentOpen
Difficulty 1/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
-
Readability 📖Open
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
-
🚨Use of innerHTMLOpen
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
Similar issues
-
[Feature]:Openenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
automated issue report
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
lirantal/discoprint#36 ·
Maintainers usually reply within 1 day
-
accepting PR Content:HTML
Difficulty 1/5 Under an hour Newbie friendliness 88/100
mdn/content#45988 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
txn2/mcp-data-platform#2030 ·
Maintainers usually reply within 1 day