console.logs and commented out code

Open
#41 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
backend

Research direction

Start with dom.js at lines 91 and 116-118, then search the project for console.log statements and commented-out code. Done means the unwanted logs and commented-out code are removed, with no such examples left in the project; the issue does not name a test to run.

Written by the indexing model from the issue text.

Description

Avoid leaving console.log statements in your code.

See: https://github.com/fac-14/NDJS-API/blob/master/dom.js#L91, https://github.com/fac-14/NDJS-API/blob/master/dom.js#L116-L118

Also, you shouldn't leave commented out code in your project. See here: https://github.com/ryanmcdermott/clean-code-javascript#dont-leave-commented-out-code-in-your-codebase

(These things should be filtered out in code review, reject the pr if there are logs or commented out code).

Dominant language
JavaScript
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fac-14/NDJS-API

All issues in fac-14/NDJS-API

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.