variables and tables comparison broken for ApplicationService
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 50/100
Research direction
Open f5_cccl/resource/ltm/app_service.py at line 62 and inspect ApplicationService equality handling for variables and tables. Reproduce comparisons where the lists have different lengths, then run the relevant project tests and confirm the update scenario no longer fails when the other list is shorter.
Written by the indexing model from the issue text.
Description
the comparison of the variables and tables in the ApplicationService in the equality operator is broken when the length of the lists change:
https://github.com/f5devcentral/f5-cccl/blob/master/f5_cccl/resource/ltm/app_service.py#L62
if not all(v in self._data['variables']
for v in other.data['variables']):
This comparison will fail when the other list is shorter than the self list.
This breaks the for example update using the k8s-bigipcontroller see https://github.com/F5Networks/k8s-bigip-ctlr/issues/1038
- Dominant language
- Python
- Stars
- 13
- Forks
- 48
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from f5devcentral/f5-cccl
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
f5devcentral/f5-cccl#250 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
f5devcentral/f5-cccl#247 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
f5devcentral/f5-cccl#246 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 20/100
f5devcentral/f5-cccl#245 ·
-
help wanted papercut
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
f5devcentral/f5-cccl#234 · 1 comment ·
All issues in f5devcentral/f5-cccl
Similar issues
-
backlog
Difficulty 1/5 Under an hour Newbie friendliness 91/100
EchoTools/nevr-runtime#1108 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
btclib-org/btclib-wallet#587 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Judgment-Pack/judgment-pack-spec#275 ·
Maintainers usually reply within 1 day