`Weibull` and `Gumbel` `survival_function` / `log_survival_function` are 0 / -inf in the upper tail
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 70/100
Línea de trabajo
Start in tensorflow_probability/python/distributions/weibull.py and gumbel.py, where survival_function, log_survival_function and log_cdf fall back to 1 - cdf and log1p(-cdf) after the cdf rounds to 1. Read the issue's reproduction snippet and run it in the upper tail to confirm 0 and -inf. Done means the Weibull and Gumbel values match the exact closed forms in the issue, with tests for the tail values added. Confirm the Gumbel gradient path depends on #2041 before deciding whether to include the other distributions.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Another one from the same comparison as #2041 :) In float32, tfd.Weibull(5., 1.).survival_function(2.) is exactly 0 and log_survival_function(2.) is -inf, where the true values are exp(-32) ≈ 1.27e-14 and -32. Gumbel has the same problem in its upper tail, and its log_cdf is -inf from about z = -4.5 down.
import tensorflow_probability as tfp
tfd = tfp.distributions
w = tfd.Weibull(concentration=5., scale=1.)
print(w.survival_function(2.).numpy()) # 0.0 exact exp(-32) = 1.27e-14
print(w.log_survival_function([1., 1.5, 2.]).numpy()) # [-1. -7.593729 -inf] exact -x**5: [-1, -7.59375, -32]
g = tfd.Gumbel(loc=0., scale=1.)
print(g.survival_function(20.).numpy()) # 0.0 exact 2.06e-09
print(g.log_survival_function(20.).numpy()) # -inf exact -20.0
print(g.log_cdf(-5.).numpy()) # -inf exact -exp(5) = -148.41
Both are a Uniform pushed through an inverted CDF bijector, and Uniform only defines _cdf, so these fall back to 1. - cdf and log1p(-cdf) after the cdf has already rounded to 1. The closed forms are one line each:
--- a/tensorflow_probability/python/distributions/weibull.py
+++ b/tensorflow_probability/python/distributions/weibull.py
def _log_prob(self, x):
return self._weibull_bijector.forward_log_det_jacobian(x, event_ndims=0)
+ def _log_survival_function(self, x):
+ return -(x / self.scale)**self.concentration
+
+ def _survival_function(self, x):
+ return tf.exp(self._log_survival_function(x))
+
--- a/tensorflow_probability/python/distributions/gumbel.py
+++ b/tensorflow_probability/python/distributions/gumbel.py
+ def _log_cdf(self, x):
+ return -tf.exp(-(x - self.loc) / self.scale)
+
+ def _log_survival_function(self, x):
+ return generic.log1mexp(tf.exp(-(x - self.loc) / self.scale))
+
+ def _survival_function(self, x):
+ return -tf.math.expm1(-tf.exp(-(x - self.loc) / self.scale))
The Gumbel log_survival_function goes through log1mexp, so its gradient past z = 17 also needs the fix in #2041.
Checked on 0.25.0 and tfp-nightly 0.26.0.dev20261112, CPU; main has the same code. GeneralizedExtremeValue, Moyal and Kumaraswamy are built the same way and also return 0, e.g. GeneralizedExtremeValue(0., 1., 0.1).survival_function(50.) is 0 where the exact value is 1.65e-8. Should those go in the same PR, or just these two to start?
- Lenguaje dominante
- Jupyter Notebook
- Estrellas
- 4.4k
- Forks
- 1.1k
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de tensorflow/probability
-
`tfp.math.log1mexp` has a NaN gradient for small inputs (reaches `OrderedLogistic.log_prob`)Posiblemente ocupada @aviralgarg05 la tomó hace 1 día. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 86/100
tensorflow/probability#2041 · 1 comentario ·
-
KL divergence between two `TransformedDistribution`s with a shared non-injective bijector (`AbsoluteValue`) returns the base KLPosiblemente ocupada @Andreas-Hum la tomó hace 19 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
tensorflow/probability#2036 ·
-
Chi2, Gamma, Beta and Binomial survival_function lose the upper tail because they fall back to 1 - cdfPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 4/5 3-5 días Aptitud para principiantes 54/100
tensorflow/probability#2040 · 1 comentario ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
tensorflow/probability#2034 ·
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
tensorflow/probability#2021 ·
Todos los issues de tensorflow/probability
Issues similares
-
priority:P2
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
osmlab/name-suggestion-index#13165 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
Los mantenedores suelen responder en 1 día
-
approved-for-pr area: extraction bug effort: S P2
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
hydra-db/selfgraph#343 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
automated endpoint-dead needs-curation
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
almanac-data/climate-almanac#139 ·
Los mantenedores suelen responder en 1 día