Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Service: a live webhook batch that fails in pipeline_sync is dropped after Stripe got a 200

Abierto
  • ¿Algo no está bien?
#353 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
postgresql, typescript
Área
backend, distributed-systems

Línea de trabajo

Start with the live batching loop in apps/service/src/temporal/workflows/pipeline-lifecycle.ts and the pipelineSync activity in apps/service/src/temporal/activities/pipeline-sync.ts; the issue also points to apps/service/src/tests/workflow.test.ts for the Temporal workflow test setup. Reproduce the failed eof and errored-stream cases with the described stubbed activity, then verify the batch is retried while successful batches still run once. Decide how retries are bounded or delayed, since the issue identifies repeated permanent failures as a risk.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happens

POST /webhooks/:pipeline_id verifies the signature, signals the pipeline workflow and answers 200 (app.ts#L973-L1004). The workflow's live loop takes up to 10 events off inputQueue with splice and awaits pipelineSync, but does not look at the eof it returns (pipeline-lifecycle.ts#L83-L101).

A processing failure comes back as a returned eof, not as a thrown error: the engine turns a throw into eof { status: 'failed' } (engine.ts#L695-L712), the Postgres destination reports a flush error as stream_status: error (index.ts#L445-L466), and the activity throws only when there is no eof at all (pipeline-sync.ts#L26). So the activity's retry policy never applies, the batch is not put back, and Stripe does not resend it, because it only retries deliveries that did not get a 2xx (webhooks docs).

An invoice.paid or customer.subscription.deleted that arrives while Postgres restarts or hits max_connections never reaches the table. The weekly reconcile does not repair it: it lists only objects created since the previous backfill (pipeline-lifecycle.ts#L121-L128, src-list-api.ts#L262-L266), so an existing invoice stays open in Postgres.

Reproduction

The workflow code from dev as of 2026-10-20, types stripped and nothing else changed, under @temporalio/testing's local server as in apps/service/src/__tests__/workflow.test.ts. Only the activities are stubbed: pipelineSync returns a failed eof for the first live batch and succeeds afterwards. Then one source_input signal with evt_1, which is what the webhook endpoint sends before answering 200:
https://github.com/terminalstate/callback-audit/tree/main/repro/stripe-sync-engine

dev with the change below
successful batch (control) evt_1 processed once once
batch eof status: 'failed' evt_1 passed to pipelineSync once, then gone processed again
eof status: 'started' with a stream errored (flush error) once, then gone processed again

Possible fix

Keep a failed batch instead of dropping it. The change the test runs with puts the events back at the head of the queue and waits before the next attempt:

const { eof } = await pipelineSync(pipelineId, { input: events, run_id: workflowInfo().runId })
operationCount++

const batchFailed =
  eof.status === 'failed' ||
  Object.values(eof.run_progress.streams).some((stream) => stream.status === 'errored')
if (batchFailed) {
  inputQueue.unshift(...events)
  await sleep(LIVE_BATCH_RETRY_DELAY)
}

It needs a growing delay or a limit, or an event that always fails is retried forever. The other option is to throw a retryable ApplicationFailure from the activity for a failed live batch, so the existing retry policy handles it.

Lenguaje dominante
TypeScript
Estrellas
1.1k
Forks
118
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de stripe/sync-engine

Todos los issues de stripe/sync-engine

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.