Feature suggestion: impl Default for Zip, and add Zip::with_shape() constructor
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
Línea de trabajo
Start by reviewing the existing Zip::from, Zip::and, and and_broadcast entry points and how they handle shapes and broadcasting. Compare the proposed Default and Zip::with_shape APIs with the motivating example; done means the API direction and resulting behavior are clearly agreed and validated.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Motivating example: I'm computing 3D positions on a unit sphere from a uniform grid of (longitude, latitude) pairs. This is what it looks like now:
const SHAPE: (usize, usize) = (HEIGHT, WIDTH);
let cell_size_lon = TAU / WIDTH as f32;
let cell_size_lat = PI / HEIGHT as f32;
let lon = Array1::linspace(cell_size_lon, TAU - cell_size_lon, WIDTH)
.into_shape((1, WIDTH)).unwrap();
let lat = Array1::linspace(-FRAC_PI_2 + cell_size_lat, FRAC_PI_2 - cell_size_lat, HEIGHT)
.into_shape((HEIGHT, 1)).unwrap();
let pos = Zip::from(lat.mapv(f32::cos).broadcast(SHAPE).unwrap())
.and(lat.mapv(f32::sin).broadcast(SHAPE).unwrap())
.and(lon.mapv(f32::cos).broadcast(SHAPE).unwrap())
.and(lon.mapv(f32::sin).broadcast(SHAPE).unwrap())
.par_map_collect(|&cos_lat, &sin_lat, &cos_lon, &sin_lon| {
Vec3::new(cos_lat * sin_lon, sin_lat, cos_lat * cos_lon)
});
I know about azip! and par_azip! but I don't think the small reduction in character count outweighs the additional "magic" syntax, so I don't use them.
Notice the distinction between Zip::from and Zip::and even though these both serve the same purpose: add another producer to the Zip.
This lopsided distinction could be eliminated if Zip implemented Default (and/or had the customary zero-args new() constructor):
let pos = Zip::default()
.and(lat.mapv(f32::cos).broadcast(SHAPE).unwrap())
.and(lat.mapv(f32::sin).broadcast(SHAPE).unwrap())
.and(lon.mapv(f32::cos).broadcast(SHAPE).unwrap())
.and(lon.mapv(f32::sin).broadcast(SHAPE).unwrap())
.par_map_collect(|&cos_lat, &sin_lat, &cos_lon, &sin_lon| {
Vec3::new(cos_lat * sin_lon, sin_lat, cos_lat * cos_lon)
});
Even nicer (for this use case) would be if we could specify the shape once up front in the constructor, so we could use and_broadcast on all producers (not just the 2nd-4th):
let pos = Zip::with_shape(SHAPE)
.and_broadcast(lat.mapv(f32::cos))
.and_broadcast(lat.mapv(f32::sin))
.and_broadcast(lon.mapv(f32::cos))
.and_broadcast(lon.mapv(f32::sin))
.par_map_collect(|&cos_lat, &sin_lat, &cos_lon, &sin_lon| {
Vec3::new(cos_lat * sin_lon, sin_lat, cos_lat * cos_lon)
});
I can't tell whether this is at all feasible or desirable, just throwing it out there for your consideration, and so that other users with similar needs can chime in.
- Lenguaje dominante
- Rust
- Estrellas
- 4.3k
- Forks
- 391
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de rust-ndarray/ndarray
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
rust-ndarray/ndarray#1612 · 1 comentario ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
rust-ndarray/ndarray#1617 · 1 comentario ·
-
Stack overflow in `triu` Abiertobug good first issue
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
rust-ndarray/ndarray#1615 · 1 comentario ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
rust-ndarray/ndarray#1610 ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 72/100
rust-ndarray/ndarray#1609 ·
Todos los issues de rust-ndarray/ndarray
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
web-infra-dev/rspack#15847 ·