Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

ISO-2022 encoders accept U+001B (and `iso2022_kr` U+000E/U+000F) although the encoding cannot represent them

Abierto
  • ¿Algo no está bien?
#160,302 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c, python
Área
backend, testing

Línea de trabajo

Start with the ASCII fast path in Modules/cjkcodecs/_codecs_iso2022.c around lines 190–200, then review the Hypothesis regression in pull request #160155, where RoundTripBugs.test_iso2022_escape is marked as an expected failure. Check the affected ISO-2022 encoders, including the SO/SI cases for iso2022_kr, and confirm the regression and error-handler tests pass when these unrepresentable control characters are rejected.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

extension-modules type-bug

Bug description

In ISO 2022, the bytes 0x1B (ESC), 0x0E (SO) and 0x0F (SI) are special control characters that aren't supposed to exist by themselves: ESC introduces the designation sequences that switch character sets (ESC $ B selects JIS X 0208, and so on), and iso2022_kr uses SO and SI to shift between ASCII and KS X 1001. There is no way to put the characters U+001B, U+000E or U+000F into an ISO-2022-JP or ISO-2022-KR byte stream; a 0x1B byte in the output is the start of an escape sequence to whoever reads it.

I would expect that attempting to encode these by themselves (or in some other invalid configuration) to be a failure state and raise UnicodeEncodeError (allowing error handlers do their thing), which is what they do for other characters the encoding has no bytes for.

What they actually do is write the control character through as a bare byte, because the encoder's ASCII fast path accepts every code point below 0x80, Modules/cjkcodecs/_codecs_iso2022.c lines 190-200. The output is not valid ISO 2022, and the matching decoder either rejects it or reads it as something else. Alone, the byte is an incomplete escape sequence:

>>> '\x1b'.encode('iso2022_jp')
b'\x1b'
>>> b'\x1b'.decode('iso2022_jp')
Traceback (most recent call last):
  File "<python-input-2>", line 1, in <module>
    b'\x1b'.decode('iso2022_jp')
    ~~~~~~~~^^^^^^^^^^^^^^
UnicodeDecodeError: 'iso2022_jp' codec can't decode byte 0x1b in position 0: incomplete multibyte sequence

Followed by the right ASCII characters, it is an escape sequence, and the text that follows is decoded in the wrong character set:

>>> 'x\x1b$B$"'.encode('iso2022_jp')
b'x\x1b$B$"'
>>> _.decode('iso2022_jp')
'xあ'

And in front of a real designation sequence it makes the decoder consume that sequence as text:

>>> '\x1b\xa0'.encode('iso2022_jp_2004')
b'\x1b\x1b$(Q)"\x1b(B'
>>> _.decode('iso2022_jp_2004')
'\x1b\x1b$(Q)"'

Every iso2022_* codec does this for U+001B. iso2022_kr does the same with SO and SI, which its decoder then interprets as shifts:

>>> '\x0e'.encode('iso2022_kr')
b'\x0e'
>>> _.decode('iso2022_kr')
''
>>> 'a\x0f가'.encode('iso2022_kr').decode('iso2022_kr')
'a가'

I do not think this can be fixed on the decoding side: the second example shows that a decoder cannot tell a stray ESC from a real one, so only refusing to encode these characters makes the round trip hold. Raising is a behavior change for text that currently encodes without complaint, but what it currently encodes to is misread by any ISO-2022 reader, not just Python's. For comparison, hz has the same problem with ~ and escapes it as ~~; the other CJK codecs pass ESC through, but for them it is an ordinary control character on both sides, so they round-trip.

Found by the Hypothesis tests in #160155, where it is pinned as RoundTripBugs.test_iso2022_escape under expectedFailure; the round-trip and error-handler tests there keep these characters out of the generated text for these codecs until it is fixed.

Lenguaje dominante
Python
Estrellas
77.7k
Forks
38.3k
Merge medio
11 h 58 min
PR fusionados (30 d)
672

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de python/cpython

Todos los issues de python/cpython

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.