BUG: `config.change_flags` is not thread-safe: concurrent graph construction can permanently clear `config.cxx`
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 52/100
Línea de trabajo
Start by reading _ChangeFlagsDecorator in pytensor/configparser.py, then inspect the config.change_flags uses in pytensor/tensor/basic.py and the concurrent reproduction in the issue. Identify how overlapping or recursive scopes affect restoration, and add regression coverage for both cases. Done means concurrent graph construction leaves config.cxx and optdb__max_use_ratio at their original values.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the issue:
config.change_flags saves the current global values on entry and writes them back on exit (pytensor/configparser.py, _ChangeFlagsDecorator). When two threads' scopes over the same flag interleave, the scope that exits last restores the temporary value that the other scope had set:
A enters: saves "g++", sets cxx=""
B enters: saves "", sets cxx=""
A exits: restores "g++"
B exits: restores "" <- process-wide, permanently
Every later scope then saves and restores the corrupted value.
Graph construction enters such a scope. Static-shape inference (pytensor/tensor/basic.py, with config.change_flags(optdb__max_use_ratio=10, cxx="")) runs whenever a shape is symbolic, for example in pt.zeros((n,)). PyMC's resolve_shapes (pymc/pytensorf.py) does the same. Building graphs on several threads at once therefore leaves cxx == "" and optdb__max_use_ratio == 10 for the rest of the process.
A shared decorator instance has the same problem without threads. For example, @config.change_flags(warn_float64="ignore") in pytensor/tensor/basic.py is a single object, and a recursive or concurrent call overwrites the values it saved.
Reproducible code example:
from concurrent.futures import ThreadPoolExecutor
import pytensor
import pytensor.tensor as pt
before = pytensor.config.cxx, pytensor.config.optdb__max_use_ratio
def build(_):
n = pt.lscalar("n")
for _ in range(500):
pt.zeros((n + 1,)) # static-shape inference enters change_flags(cxx="")
with ThreadPoolExecutor(8) as executor:
list(executor.map(build, range(8)))
print(before, (pytensor.config.cxx, pytensor.config.optdb__max_use_ratio))
# ('/usr/bin/g++', 8.0) ('', 10.0)
xs = pt.dvectors(*(f"x{i}" for i in range(33)))
f = pytensor.function(xs, pt.exp(sum(xs)), mode="CVM")
f(*[[0.0]] * 33)
Error message:
NotImplementedError: Elemwise.perform (Python mode) does not support more than 32 operands. Use the C backend or disable Elemwise fusion.
PyTensor version information:
PyTensor 3.3.1 (pip), Python 3.14, Linux x86_64, with g++ as cxx. The same code is on main (332ea8fb7).
Context for the issue:
- Every C-linked function compiled afterwards in the process silently falls back to Python implementations. Already compiled functions are unaffected.
- Fused elemwise graphs with more than 32 operands then raise the error above.
- Python and C implementations differ at rounding level, so seeded results can change without an error, depending on thread timing earlier in the process. I measured differences of about 1e-14 in a downstream PyMC model.
I hit this in a library that fits independent models on worker threads with PyMC. A long-running process lost C compilation after one threaded fit, and an unrelated later computation failed with the error above.
- Lenguaje dominante
- Python
- Estrellas
- 654
- Forks
- 258
- Merge medio
- 2 d 7 h
- PR fusionados (30 d)
- 39
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de pymc-devs/pytensor
-
Docs of mode still mentions C/CVM as the default with FAST_RUNPosiblemente ocupada @ADITYASINGH1206 la tomó hace 8 días. Abiertodocs
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
pymc-devs/pytensor#2641 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Update conditions page in docsAbiertodocs
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
-
BUG: geomspace returns wrong sign for the endpoints when start and stop are negativePosiblemente ocupada @mayuriphad la tomó hace 27 días. Abierto
Dificultad 2/5 Menos de una hora Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día
-
Reciprocal.impl computes np.float32(1.0) / x: float32 precision for float64 scalars under NEP 50 (Python linker)Quizá libre de nuevo Un pull request para esta issue se cerró sin fusionarse. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
pymc-devs/pytensor#2430 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
pymc-devs/pytensor#2428 · 5 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de pymc-devs/pytensor
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
dgunning/edgartools#2019 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
topoteretes/cognee#6818 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
source_verification_agent: no outcome when the publisher confirms a work but its DOI resolves to a different recordPosiblemente ocupada @pinjun99 la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Imbad0202/academic-research-skills#1159 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
[Bug]: DoubleMLData.from_arrays checks the treatment d with force_all_x_finite instead of force_all_d_finitePosiblemente ocupada @leninworld la tomó hoy. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
DoubleML/doubleml-for-py#471 ·
Los mantenedores suelen responder en 1 día