Text rendering with word wrap and RTL often clips

Abierto
#664 4 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
javascript
Área
frontend

Línea de trabajo

Start by locating the word-wrapping routine that splits text into words and measures each line; the issue identifies trailing spaces and subtracting a space width as the cause. Trim trailing spaces from wrapped lines, then check that RTL text no longer clips while Center and Right alignment remain accurate. The payload does not name a file or test, so first find the relevant implementation and its existing text rendering tests.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
  • A bug in the API:
    • Phaser version(s): 2.12.0, 2.15.0
    • What steps produce the bug: Use RTL text, such as Arabic, with word wrap, so the text wraps.
    • What should happen: All letters should render properly.
    • What happens instead: One more more letters of the widest line(s) will be truncated on the right.

When the word wrapping routine splits text into words by spaces, each line's string (except possibly the last line) has a trailing space. Each line is then measured, and the width of a space is removed from the line length to account for that trailing space (necessary for accurate Center or Right alignment). For LTR languages, the trailing space for the widest line(s) are actually clipped off by the right side of the context's rectangle because of this. Since spaces are not visible, this is not an issue.

For a RTL language the trailing space is actually drawn on the left. Since text rendering is positioned by the left edge, the subtraction of the width of a space from the width of the line may result in the right side of the text clipped by the width of the space.

Fix: Instead of measuring lines of word wrapped split text with trailing space included, then subtracting the width of a space, simply trim the trailing space of each word wrapped line from the string.

Lenguaje dominante
JavaScript
Estrellas
1.4k
Forks
485
Merge medio
1 d 2 h
PR fusionados (30 d)
9

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de phaserjs/phaser-ce

Todos los issues de phaserjs/phaser-ce

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.