Supporting multiple interventions
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start with set_intervention_ach(), generate_setting_intervention_switches(), and calculate_efficacy_from_ach(); the issue says these currently store and read a single intervention. Review the ACH framework introduced in #142 and compare the indexing approach in malariasimulation’s R/mda_parameters.R. Done means a simulation can use multiple interventions per setting, with indexing, coverage behavior, joint coverage, and parameter naming resolved.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Work in progress on branch `multiple-interventions'.
The ACH intervention framework (added in #142) currently supports one intervention per setting (workplace, school, leisure, household, or joint). Generalising it to several interventions in a single simulation raises the points below, collected from review of #142.
Points to address
- Single intervention stored as a length-1 list.
set_intervention_ach()wraps the intervention inlist(), and downstream code readsinterventions[[1]](e.g.$coverageingenerate_setting_intervention_switches(), and incalculate_efficacy_from_ach()). Callingset_intervention_ach()twice for the same setting overwrites the first intervention rather than adding to it. - Indexing interventions. Interventions need a way to be identified and looked up. Options: key them by the
namefrommake_intervention(), or use a user-assigned index, as in malariasimulation: https://github.com/mrc-ide/malariasimulation/blob/master/R/mda_parameters.R - Coverage across interventions. Decide whether coverage of multiple interventions is clumped (same locations covered) or independent.
- Joint coverage.
intervention_joint_coverageis taken from a single intervention; check it behaves correctly once there is more than one. - Parameter naming. The
intervention_<setting>_<param>convention may not scale to several interventions. One option isaqi_intervention_<setting>_<param>; this needs revisiting as part of this work.
From Tom: "In malariasimulation, where multiple interventions of a similar type are used the user assigns them an index which then helps the internal code work through this kind of issue (see https://github.com/mrc-ide/malariasimulation/blob/master/R/mda_parameters.R if interested). Here we have the intervention name from make_intervention which feels like it should be a useful way to resolve the multiple intervention issue."
- Lenguaje dominante
- R
- Estrellas
- 8
- Forks
- 4
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de petal-code/helios
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
petal-code/helios#174 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
petal-code/helios#173 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 84/100
petal-code/helios#166 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 92/100
petal-code/helios#161 ·
-
run_simulation() is not reproducible from seed: the leisure draw uses dqrng's own RNGPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
petal-code/helios#157 · 1 comentario ·
Todos los issues de petal-code/helios
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 71/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
OHDSI/PatientLevelPrediction#688 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
rfordatascience/tidytuesday#1098 ·