[5.x] TIA: replayed tests report stale/incomplete coverage, breaking --min
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
Línea de trabajo
Start by tracing Pest\Plugins\Tia coverage handling, especially KEY_COVERAGE_CACHE (coverage.bin.gz) and the mergePerTestFiles() call that combines collector and recorder data. Reproduce with --coverage --tia --min=100 using a cold and warm ~/.pest/tia cache, then verify that replayed tests produce the same coverage totals and pass the minimum gate as a fresh run.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
ENVIRONMENT
pestphp/pest v5.0.2
phpunit/phpunit 13.2.6
phpunit/php-code-coverage 14.2.4
laravel/framework v13.23.0
PHP 8.4.20
Coverage driver pcov 1.0.13-dev (Xdebug not installed)
OS Linux 6.17.0 (Docker, SLES-based image)
Suite size 666 tests / 1687 assertions
SUMMARY
When --coverage and --tia are combined, coverage numbers depend on whether the
TIA cache is warm. With a cold cache the suite reports 100.0%. Running the exact
same command again — no source or test changes in between — reports 99.9% and
fails --min=100.
The drop is deterministic and always hits the same two files. Those files are
fully covered: running --coverage without --tia reports them at 100.0%.
This makes --coverage --tia unusable as a CI gate, and it is misleading during
development: it points at files as under-covered when their tests exist and pass.
STEPS TO REPRODUCE
-
Have a suite that reaches 100% line coverage.
-
Clear the TIA cache and run with coverage:
rm -rf ~/.pest/tia
php -d pcov.enabled=1 vendor/bin/pest --coverage --tia --min=100-> Tests: 666 passed (1687 assertions)
-> Total: 100.0 %
-> exit code 0 -
Run the exact same command again, changing nothing:
php -d pcov.enabled=1 vendor/bin/pest --coverage --tia --min=100
-> Tests: 666 passed (1687 assertions, 666 replayed)
-> Domain/B2B/Actions/UpdateProductAction ............... 94 / 97.4%
-> Livewire/B2B/Produtos/AbstractProdutosTable ... 306..348 / 98.9%
-> Total: 99.9 %
-> FAIL Code coverage below expected 100.0 %, currently 99.9 %
-> exit code 1 -
Confirm the files are actually covered, without TIA:
php -d pcov.enabled=1 vendor/bin/pest --coverage
-> Domain/B2B/Actions/UpdateProductAction ............... 100.0%
-> Livewire/B2B/Produtos/AbstractProdutosTable .......... 100.0%
-> Total: 100.0 %
Steps 2-4 reproduce every time, in this order.
EXPECTED BEHAVIOUR
Coverage totals should be identical whether tests are executed or replayed from
the TIA cache. A replayed test should contribute the same coverage data it
contributed when it last ran.
ACTUAL BEHAVIOUR
Replayed tests contribute incomplete coverage data. The reported total drops from
100.0% to 99.9%, and --min=100 fails on a suite that has not changed.
NOTES THAT MIGHT HELP NARROW IT DOWN
-
The uncovered ranges reported under TIA are not random. They are always the same
two files, and always the same line ranges:- UpdateProductAction line 94 — a
match ($segmento)expression whose two arms
are each exercised by a different test file.
Covered by 2 test files. - AbstractProdutosTable lines 306..348 — a
match ($result)with four arms plus
two public methods.
Covered by 3 test files (one per concrete subclass, plus a permissions test).
Both regions happen to be covered by more than one test file, and both are
matchexpressions whose arms are split across those files. We could not turn
that into a conclusion, though: plenty of other classes in this suite are also
touched by many test files (SegmentoEnum by 40) and stayed at 100.0% under TIA.
So multi-file coverage alone is not sufficient to trigger it — reporting the
observation as-is rather than a diagnosis. - UpdateProductAction line 94 — a
-
The tests covering those regions were not affected by the change that warmed the
cache, so they were replayed rather than re-executed. -
Relevant-looking internals: Pest\Plugins\Tia has
piggybackCoverage,
KEY_COVERAGE_CACHE ('coverage.bin.gz') and amergePerTestFiles()call that
merges the collector's per-test files with the recorder's. If the merge keeps
only one contributor per file/line, a region covered by several test files would
lose the contributions of the replayed ones — which matches what we observe. -
Cache location in our setup: ~/.pest/tia/-/
coverage.bin.gz (1.0 MB)
graph.json (358 KB) -
No custom coverage config: no --coverage-filter, no --path-coverage, plain
phpunit.xml source include of app/. -
--tiaon its own (no coverage) is correct: it replays properly and the suite
passes in 0.86s vs 61s. Only the coverage numbers are affected.
IMPACT / CURRENT WORKAROUND
We can't use --coverage --tia as a gate. We split the two uses in composer
scripts, wiping the TIA cache before any coverage run:
"test:tia": "pest --tia"
"test:coverage": wipe ~/.pest/tia, then "pest --coverage --min=100"
That restores a trustworthy number, at the cost of losing TIA's speed for any run
that also measures coverage.
- Lenguaje dominante
- Sin datos de lenguaje
- Estrellas
- 56
- Forks
- 180
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de pestphp/docs
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
-
Add light-mode Abierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
-
Dificultad 3/5 1-2 días Aptitud para principiantes 30/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 45/100
-
documentation versioning Abierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
Todos los issues de pestphp/docs
Issues similares
-
area:spec bug good first issue ready-for-agent
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
low smart-contract Stellar Wave testing
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Web3Novalabs/Nevo#1376 · 3 comentarios ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 60/100
github/gh-aw-mcpg#13748 ·