[feat]: add `aria-orientation` support to `TabsAriaController`
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 57/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- typescript
- Área
- accessibility, frontend
Línea de trabajo
Start with core/pfe-core/controllers/tabs-aria-controller.ts and trace how pf-v5-tabs supplies its tablist and vertical state, then check how RovingTabindexController reads orientation. Implementing this spans controller ownership, component wiring, runtime orientation changes, and SSR behavior; the issue names controller tests as the place to cover horizontal, vertical, and switching orientation. Done when the tablist exposes the correct orientation and keyboard navigation follows it.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Summary
TabsAriaController does not set aria-orientation on the tablist, and nothing wires a tabs element's vertical/horizontal state into the accessibility tree.
Current state
TabsAriaController (core/pfe-core/controllers/tabs-aria-controller.ts) only:
- sets
role="tab"androle="tabpanel"on slotted children - sets
aria-controlsandaria-labelledbyinhostUpdated()
It never touches the tablist itself. In pf-v5-tabs, the tablist is an inner <div id="tabs" role="tablist"> with no aria-orientation, while the element has a vertical boolean that only drives styling.
// tabs-aria-controller.ts
hostUpdated(): void {
for (const [tab, panel] of this.#tabPanelMap) {
panel.setAttribute('aria-labelledby', tab.id);
tab.setAttribute('aria-controls', panel.id);
}
}
Problems
-
Missing ARIA state. A vertical tablist has no
aria-orientation="vertical", so assistive tech reports the wrong orientation. Per the ARIA spec,aria-orientationdefaults tohorizontalontablist, so a vertical tablist is actively announced incorrectly. -
Keyboard behavior is not orientation-aware.
ATFocusController.onKeydownreadsaria-orientationfrom the items container to decide which arrow keys move focus:const orientation = this.options.getOrientation?.() ?? this .#itemsContainerElement ?.getAttribute('aria-orientation') as 'horizontal' | 'vertical' | 'grid' | 'undefined';Because the tablist never has the attribute and
pf-v5-tabsdoes not passgetOrientationtoRovingTabindexController, both Left/Right and Up/Down move focus in a horizontal tablist. The APG tabs pattern expects Left/Right for horizontal tablists and Up/Down for vertical ones. -
Duplicated ownership.
role="tablist"is hardcoded in thepf-v5-tabsrender while the rest of the tabs ARIA is managed by the controller. This split makes it easy for one side to drift from the other.
Proposed direction
- Add tablist ARIA management to
TabsAriaController, includingaria-orientation. - Accept an orientation source in
TabsAriaControllerOptions, for exampleorientation?: 'horizontal' | 'vertical'orgetOrientation?: () => 'horizontal' | 'vertical', and reflect it toaria-orientationon the tablist (omit the attribute for the horizontal default, or set it explicitly, whichever the team prefers). - Give the controller a way to reference the tablist element. Since the host is not the tablist in
pf-v5-tabs, this likely needs an option such asgetTabList?: () => HTMLElement | null, or a documented contract that the host itself carriesrole="tablist". - Feed the same orientation to
RovingTabindexControllerviagetOrientation, or rely on the attribute once the controller sets it on the items container. - Consider moving
role="tablist"ownership into the controller as part of this change. - Keep the SSR path safe (
isServerguard) and add controller tests covering horizontal, vertical, and switching orientation at runtime.
Impacted components
core/pfe-core/controllers/tabs-aria-controller.tselements/pf-v5-tabs<pf-v6-tabs>implementation in #3040
Related issues
- #3040
Jira Issue: FELT-5230
- Lenguaje dominante
- TypeScript
- Estrellas
- 397
- Forks
- 109
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de patternfly/patternfly-elements
-
[feat]: support non-element `ReactiveControllerHost` in pfe-core controllersQuizá libre de nuevo @bennypowers la tomó hace 30 días y no hay ningún pull request abierto. Abiertobreaking change feature needs discussion
patternfly/patternfly-elements#3166 · 1 asignado ·
-
[bug] ssr-shims.js uses deprecated globalThis.litSsrCallConnectedCallbackPosiblemente ocupada @zeroedin la tomó hace 106 días. Abiertobug
patternfly/patternfly-elements#3158 · 1 asignado ·
-
chore: evaluate removing isolatedDeclarations from tsconfigQuizá libre de nuevo @bennypowers la tomó hace 196 días y no hay ningún pull request abierto. Abierto
patternfly/patternfly-elements#3136 · 1 comentario · 1 asignado ·
-
chore: update docs scaffolding for v6 elementsQuizá libre de nuevo @zeroedin la tomó hace 196 días y no hay ningún pull request abierto. Abiertodocs
patternfly/patternfly-elements#3131 · 1 asignado ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
patternfly/patternfly-elements#3122 ·
Todos los issues de patternfly/patternfly-elements
Issues similares
-
[Site] Active section detection should respect scroll-margin-topPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertoarea/web reproduced type/bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
anomalyco/opencode#65384 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
swc-project/swc-ai-issues#1001 ·
-
Add: Da Vinci Asia VietnamAbiertocheck:passed streams:add
Dificultad 1/5 Menos de una hora Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
-
fix(table): CollapseColumn uses wrong caret icon for expandable row togglePosiblemente ocupada @redhat-chai-bot la tomó hoy. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
patternfly/patternfly-react#12727 ·
Los mantenedores suelen responder en 1 día
-
CLI OAuth login fails behind an authenticating proxy: GET /api/v1/user omits Proxy-AuthorizationAbierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
lightdash/lightdash#33086 · 1 comentario ·
Los mantenedores suelen responder en 1 día