refactor: split SettingsDialog into per-panel sub-components

Abierto
  • ¿Algo no está bien?
#4 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
52/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Tranquilo
Stack tecnológico
react, typescript
Área
desktop, frontend

Línea de trabajo

Start with src/components/settings/SettingsDialog.tsx and trace how the tab navigation selects each panel and how settings are read and saved. Extract the panels into src/components/settings/panels/, keeping the parent responsible for routing and passing settings through props or the store hook. Done means each panel is under 200 lines, settings persist after an app reload, and TypeScript, tests, and the build pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

good first issue help wanted refactor

src/components/settings/SettingsDialog.tsx is 1,321 lines. Each settings panel (General, Editor, Explorer, AI, Keymaps, Templates, Updates) is its own world but they all share one giant file.

What to extract

One PR per panel is fine. Order suggestion (lightest first):

  1. <AISettingsPanel> — the AI provider config (OpenAI / Anthropic / Google / Ollama selector, API key, endpoint, model).
  2. <KeymapsPanel> — preset selector + custom-action overrides.
  3. <TemplatesPanel> — live-template CRUD.
  4. <UpdatesPanel> — the in-app updater UI.
  5. <ExplorerSettingsPanel> — the show/hide toggles.
  6. <GeneralSettingsPanel> — everything else.

Suggested approach

  • Components live in src/components/settings/panels/.
  • The parent SettingsDialog keeps the tab nav + active-panel routing.
  • Each panel takes settings + setSetting (or its store hook) as props — no panel should useSettings() independently if the parent already has it.

Done criteria

  • SettingsDialog.tsx becomes a router; each panel < 200 lines.
  • All settings still persist correctly across app reloads (manual test).
  • TypeScript / tests / build green.

Out of scope

  • Redesigning the visual layout.
  • Adding new settings.

Audit reference

K4 in the pre-launch audit.

Lenguaje dominante
TypeScript
Estrellas
6
Forks
1
Merge medio
17 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de openidle-dev/queryden

Todos los issues de openidle-dev/queryden

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.