Migrate remaining native <select>s to the Select primitive (missed by #151)

Abierto
  • ¿Algo no está bien?
#192 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
react, typescript
Área
design, frontend

Línea de trabajo

Start in src/components/ui/Select.tsx to understand the primitive’s options, value, and onValueChange API, then inspect the 13 listed native controls in SettingsDialog.tsx, Toolbar.tsx, CreateTableDialog.tsx, and ConfirmDialog.tsx. Triage the no-op database selector in Toolbar.tsx first. Done means every remaining control is migrated or removed, preserves current behavior, and has been checked in Dark, Light, and Blue themes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

The Radix-backed Select primitive migration (#151 / #152) replaced native <select> dropdowns — whose OS-rendered popup list ignores the app theme (notably unreadable on Windows dark/blue themes) — with themed popovers. Several call sites were missed. The Theme dropdown in SettingsDialog was migrated separately while fixing the light/blue themes; this issue tracks the rest.

Remaining native <select>s (13)

src/components/settings/SettingsDialog.tsx (9)

  • L234 — Editor Font Family (Appearance)
  • L303 — Keymap preset
  • L340 — Suggest objects from (SQL Completion)
  • L354 — Qualify objects (SQL Completion)
  • L683 — Import/Export delimiter
  • L712 — Import/Export quote char
  • L819 — AI model (AI Assistant)
  • L873 — Copy method (Copy/Transfer)
  • L945 — Copy logging level (Copy/Transfer)

src/components/layout/Toolbar.tsx (2)

  • L80 — Database selector (note: onChange is a no-op () => {} — verify whether this control is vestigial and should be removed rather than migrated)
  • L125 — Transaction isolation level

src/components/explorer/CreateTableDialog.tsx (1)

  • L138 — Column data type (high-traffic)

src/components/ui/ConfirmDialog.tsx (1)

  • L145 — Select-style confirm input
Acceptance
  • Each control uses src/components/ui/Select.tsx (options/value/onValueChange), preserving current values/behavior.
  • Verified readable across Dark, Light, and Blue themes (the popup list must follow the theme, not the OS).
  • L80 in Toolbar triaged: migrate or remove the dead no-op selector.
Lenguaje dominante
TypeScript
Estrellas
6
Forks
1
Merge medio
17 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de openidle-dev/queryden

Todos los issues de openidle-dev/queryden

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.