Adopt ESLint for frontend static analysis

Abierto
  • ¿Algo no está bien?
#33 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
43/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
eslint, github-actions, react, tauri, typescript
Área
ci-cd, developer-experience, frontend, testing

Línea de trabajo

Start by reading the current frontend scripts and CLAUDE.md, then inspect .github/workflows/ci.yml and CONTRIBUTING.md to see how checks are run and documented. Add the flat ESLint setup and npm run lint described in the issue, then run it on main and address violations without undocumented suppressions. Done means lint passes locally and CI runs it on every PR.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Context

Today the only frontend static-analysis gate is npx tsc --noEmit (per CLAUDE.md). CodeRabbit also flags this on every PR ("ESLint skipped: no ESLint configuration detected").

tsc catches type errors but misses real classes of bugs in a React + Tauri codebase:

  • React Hooks violations — missing useEffect deps, conditional hooks, stale closures. eslint-plugin-react-hooks's exhaustive-deps is the highest-value rule here and catches actual runtime bugs tsc cannot see.
  • Floating promises — easy to miss in a Tauri app where every IPC call is async. @typescript-eslint/no-floating-promises catches them.
  • Contributor PR floor — raises baseline quality without manual nitpicking in review.

Proposal

Minimal flat-config ESLint setup, additive to existing CI.

Scope:

  • eslint.config.js (flat config)
  • Presets: @eslint/js recommended, typescript-eslint recommended (not recommended-type-checked — too noisy on first run), eslint-plugin-react-hooks, eslint-plugin-react-refresh
  • New script: npm run lint
  • Wire into .github/workflows/ci.yml alongside tsc --noEmit
  • Update CLAUDE.md to reflect ESLint as a gate
  • Update CONTRIBUTING.md to mention the lint step

Explicitly out of scope:

  • Prettier — separate decision, separate PR
  • recommended-type-checked rules — can be enabled later once the codebase is clean against the base ruleset
  • Backend (Rust) — cargo clippy -- -D warnings is already wired

Acceptance criteria

  • npm run lint passes on main
  • CI runs lint on every PR
  • No suppressions added to make the initial pass green that don't have a tracking comment or follow-up issue
  • CLAUDE.md updated

Notes

Expect a non-trivial first-pass cleanup. If the violation count is large, split into:

  1. Land config + CI wiring with whatever minimum suppressions are needed
  2. Follow-up PR(s) to remove suppressions
Lenguaje dominante
TypeScript
Estrellas
6
Forks
1
Merge medio
17 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de openidle-dev/queryden

Todos los issues de openidle-dev/queryden

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.