Collect server subprocess coverage and report production-focused coverage gaps
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- rust
- Área
- ci-cd, testing-qa
Línea de trabajo
Start with crates/pet/tests/jsonrpc_client.rs, especially the server shutdown path referenced in the issue, and review tracking items #528 and #529 before changing coverage orchestration. Verify the profile-loss cause with the existing black-box server tests and coordinate transport fixtures with #532. Done means subprocess profiles are diagnosed and included, production and changed-code reports are distinguished, regression checks remain intact, and macOS coverage or its blocker is documented.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Tracking plan: #528
Priority: P1 for coverage integrity. Evidence: exact-audit-revision LCOV artifacts, with profile-loss cause to verify.
Problem and evidence
The coverage baseline at 4e523ba reports 80.81% Linux / 78.23% Windows line coverage and 84.81% / 81.57% function coverage. Nevertheless, both artifacts record zero execution for the transport loop, reply writers, and RPC entry handlers, despite black-box server tests exercising some of those paths.
The test client kills the server on Drop, which likely prevents normal LLVM profile flushing. Verify that cause rather than equating zero recorded coverage with absence of tests.
Aggregate coverage also includes inline test code. Restricting JSONRPC orchestration LCOV to executable lines before its test module gives 415/900 covered lines (46.1%) on both measured platforms. Conda/Poetry subprocess and diagnostic paths contain substantial unrecorded coverage. There is no macOS coverage job, although macOS functional tests exist.
Scope
- Collect instrumented server-subprocess profiles via normal bounded shutdown, unique profile output names, and inclusion in the final report.
- Add production-focused and changed-code coverage reporting; retain existing whole-workspace metrics for continuity rather than silently changing their meaning.
- Add focused failure-path/branch tests for transport and handler behavior and measure macOS-specific runtime paths with a macOS coverage job.
- Keep exact-base comparisons and fail-closed behavior. Do not optimize for a headline percentage by adding trivial tests or excluding difficult production paths.
Acceptance criteria
- A known black-box request visibly increases coverage in the corresponding handler, transport loop, and response writer on supported platforms.
- A normal server shutdown flushes/collects the expected profile; missing subprocess profiles are diagnosed rather than treated as success.
- Reports distinguish production code from inline tests and expose uncovered changed production paths.
- Targeted branch/error-path reporting is introduced where supported, with documented tool/platform limits.
- macOS coverage is measured, or a concrete toolchain blocker is recorded and split into a linked follow-up before this item is closed.
- Comparator changes and any baseline/schema transition have tests; exact-base line/function regression protection is preserved.
Dependencies and prior work
Depends on #529 for clean shutdown. Coordinate transport fixtures with #532. #522 / #524 is the existing fork-quality-workflow prerequisite. This extends the completed coverage expansion in #389 and gate enforcement in #503; it does not reopen those completed tasks or assert that the current gate is absent.
- Lenguaje dominante
- Rust
- Estrellas
- 207
- Forks
- 45
- Merge medio
- 3 d 12 h
- PR fusionados (30 d)
- 11
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de microsoft/python-environment-tools
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
-
debt
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
microsoft/python-environment-tools#538 · 1 comentario ·
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
-
debt
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
microsoft/python-environment-tools#533 · 1 comentario ·
Todos los issues de microsoft/python-environment-tools
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
state:needs triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
zed-industries/zed#64680 · 2 comentarios ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
RustPython/RustPython#8802 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
TheLarkInn/aipm#2390 ·