Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

MAINT Extract attack factory adversarial configuration assembly

Abierto
#2,765 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
ai, tooling

Línea de trabajo

Wait for prerequisite #2494 to settle, then read pyrit/scenario/core/attack_technique_factory.py, especially create() and _build_adversarial_config(), alongside tests/unit/scenario/core/test_attack_technique_factory.py. Follow doc/code/framework.md and the scenario, Python, and test instructions. Done means the helper is used by the factory while preserving the documented configuration, prompt, conflict, and repeated-creation behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

not ready yet
Is your feature request related to a problem? Please describe.

AttackTechniqueFactory.create() and _build_adversarial_config() combine adversarial target selection, prompt resolution, conflicting-override checks, and attack construction. These are configuration rules that can be isolated without changing the attack algorithm or the factory's public interface.

This is F2 of three small factory extractions. Not ready yet: #2494 is actively changing this exact path to add benchmark-owned prompt guidance. Wait until that PR lands or its design is otherwise resolved, then reassess the extraction against the resulting mainline code before adding help wanted. Do not implement a competing version of its prompt behavior.

Describe the solution you'd like

After the prerequisite is resolved, extract adversarial configuration assembly into a small private helper at the technique layer and wire it into the factory. Preserve the resulting mainline behavior rather than restoring the pre-#2494 implementation.

  • Keep target precedence and the distinction between baked-in configuration, create-time inputs, and defaults explicit.
  • Preserve conflicts and conditional construction: do not silently override a baked-in custom target or prompt, or create adversarial configuration for an incompatible attack.
  • Keep system-prompt and seed-prompt assembly together with their validation. Reuse existing prompt/model helpers rather than duplicating them.
  • If #2494 lands, preserve its final guidance-prefix, simulated-conversation, prompt-metadata, and identity behavior as part of the extraction.

Acceptance criteria:

  • Default, baked-in, and create-time configurations produce the same target and prompts, with unchanged errors for conflicting inputs.
  • Supported string and SeedPrompt inputs retain their existing handling.
  • The public factory API and registered techniques keep their behavior; no global factory or canonical prompt is mutated by creating a specialized attack instance.
  • Any merged #2494 guidance composition retains native prompt parameters/schema/format and the intended component identity.
  • Factory and affected prompt/configuration coverage protects the full override matrix and repeated creation with different inputs.
  • The helper is used by the existing factory path, not left as unused scaffolding.
Describe alternatives you've considered, if relevant

Do not move packaging rules into executors or move attack turn management, pruning, backtracking, or scoring decisions into the factory. Do not combine this with a broad cleanup of defaults in older executors. Constructor compatibility and converter composition are separate, independently scoped extractions.

Additional context

Starting points: pyrit/scenario/core/attack_technique_factory.py, particularly create() and _build_adversarial_config(), and tests/unit/scenario/core/test_attack_technique_factory.py. Follow doc/code/framework.md and the scenario, Python, and test instructions.

Readiness prerequisite: #2494. Its current changes also touch per-instance seed-technique prefix composition, so confirm the final boundary after it settles. This issue is a behavior-preserving reorganization, not authorization for new prompt semantics or a public API redesign.

Lenguaje dominante
Python
Estrellas
4.5k
Forks
896
Merge medio
3 d 5 h
PR fusionados (30 d)
200

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/PyRIT

Todos los issues de microsoft/PyRIT

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.