Fix accessibility issues found by the Storybook catalog

Abierto
  • ¿Algo no está bien?
#390 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
57/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
react, storybook, typescript
Área
accessibility, frontend

Línea de trabajo

Start with ui/host/src/catalog/accessibility.ts to see the exceptions, then inspect shell.tsx, the dashboard and settings pages, dashboards/viz/health-pieces.tsx, rail.tsx, dashboards/panel-card.tsx, and settings.tsx. Run just design-check after removing an exception, or open the affected story with just design and check its Accessibility panel. Done when each listed issue is fixed and its exception is deleted.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

The Storybook catalog runs axe on every story with a11y.test: "error". To keep it green, these existing issues in the shipping markup are excepted in ui/host/src/catalog/accessibility.ts. Fix each one, then delete its exception.

  • Nested and duplicate <main> landmarks. AppShell.Main in shell.tsx and the dashboard and settings pages each render a <main>. axe reports landmark-main-is-top-level (one nested main), landmark-no-duplicate-main (two mains) and landmark-unique (two unnamed mains).
  • Degraded health label contrast, light scheme. The degraded Metric label in dashboards/viz/health-pieces.tsx inherits warn text #c87d21, which is 3.275:1 on white (color-contrast, needs 4.5:1). Mantine's c prop overrides the component's darker status ink.
  • Selected chat timestamp contrast, light scheme. In rail.tsx, the dimmed timestamp on the active chat row is 3.901:1 against the selected background (color-contrast).
  • Panel loader label. The labelled Mantine Loader in dashboards/panel-card.tsx (aria-label="Loading panel") renders a span with no role (aria-prohibited-attr). Give it role="status" or use visually hidden text.
  • Settings documentation link. The "Sending telemetry" link in settings.tsx inherits the text colour and underlines only on hover. That is 1.289:1 against the surrounding text (link-in-text-block). Underline it at rest, or give it link colour.

Reproduce: run just design-check after removing an exception, or open the story in just design and check the Accessibility panel.

Lenguaje dominante
Go
Estrellas
11
Forks
0
Merge medio
7 h 39 min
PR fusionados (30 d)
97

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de labstack/fanout

Todos los issues de labstack/fanout

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.