[MiniMax-H3] Load the pruned ComfyUI checkpoints and add single-file support for MiniMax-H3-Image
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 28/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Área
- machine-learning
Línea de trabajo
The referenced implementation is PR #15299, already open, so start by reading that diff rather than the issue text alone. The transformers live under src/diffusers/models/transformers/ (MiniMaxH3Transformer3DModel, MiniMaxH3ImageTransformer2DModel), and the single-file mapping is in src/diffusers/loaders/single_file_model.py plus the MiniMax-H3 original-config file in single_file_utils.py. The open design question — whether a new config_from_checkpoint_fn key in the single-file registry is acceptable — needs a maintainer answer before any patch, and done means a pruned ComfyUI checkpoint loads through from_single_file with tests covering the unstripped config path.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Is your feature request related to a problem? Please describe.
ComfyUI distributes pruned MiniMax-H3 checkpoints (Comfy-Org/MiniMax-H3, Comfy-Org/MiniMax-H3-Image). They cannot be loaded in diffusers today:
- The pruned files replace the timestep MLP and the wide AdaLN projections (about 40% of the parameters) with the activated timestep curve sampled on a 1025-point grid (
adaln_t_table) and 8-input AdaLN projections.MiniMaxH3Transformer3DModelhas no module that matches these weights, andfrom_single_filerefusesadaln_t_table. MiniMaxH3ImageTransformer2DModelhas no single-file support at all (noFromOriginalModelMixin), and the ComfyUI file stores the PDD heads as a stacked bank (head 0 plus per-step offsets) rather than aspdd_proj_out.{i}.
Describe the solution you'd like.
- An opt-in config field (
adaln_curve_grid) on both transformers. When set,time_embedderis a lookup of the sampled curve, linearly interpolated as ComfyUI does, and the AdaLN projections skip their SiLU. Stock configs keep their current behaviour. from_single_filefor both transformers: mapadaln_t_tableto the table, unstack the PDD head bank for the image model, and refuse quantized ComfyUI files with a message naming the bf16 file.
transformer = MiniMaxH3ImageTransformer2DModel.from_single_file(
"https://huggingface.co/Comfy-Org/MiniMax-H3-Image/blob/main/diffusion_models/minimax_h3_image_pruned_bf16.safetensors",
dtype=torch.bfloat16,
)
Design question for maintainers
The repository config on the Hub describes the unpruned model, and no Hub repo carries a pruned diffusers config that a model type could point at. So the pruned shape (adaln_curve_grid, time_embed_dim) has to be read off the checkpoint itself. #15299 does this with a new optional key in the single-file registry, config_from_checkpoint_fn. Is a new registry key acceptable here, or would you prefer another route (for example a separate model type with its own config)?
Additional context.
Implementation proposed in #15299.
- Lenguaje dominante
- Python
- Estrellas
- 34.9k
- Forks
- 7.5k
- Merge medio
- 3 d 16 h
- PR fusionados (30 d)
- 65
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de huggingface/diffusers
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
huggingface/diffusers#15363 ·
Los mantenedores suelen responder en 1 día
-
`ZImageImg2ImgPipeline` / `ZImageInpaintPipeline`: explicit height/width different from the input image raises RuntimeErrorPosiblemente ocupada @chessing234 la tomó hace 1 día. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
huggingface/diffusers#15337 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
Multi-vector textual inversion uses only the first vector when the token has uppercase letters (transformers v5)Posiblemente ocupada @sunhouy la tomó hace 2 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
huggingface/diffusers#15313 ·
Los mantenedores suelen responder en 1 día
-
TCDScheduler advances the generator on the final step of a strength-truncated custom schedulePosiblemente ocupada @SIDDARTHAREDDY8 la tomó hace 5 días. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
huggingface/diffusers#15288 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
unload_textual_inversion(token) leaves the extra tokens of a multi-vector embedding behind, so it can't be loaded againPosiblemente ocupada @sohailshk la tomó hace 11 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
huggingface/diffusers#15211 · 3 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de huggingface/diffusers
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 73/100
Los mantenedores suelen responder en 1 día
-
Unused loot bag group names left in dreamcraft en_US.langPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. AbiertoStatus: Triage Suggestion
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
GTNewHorizons/GT-New-Horizons-Modpack#27789 ·
Los mantenedores suelen responder en 1 día
-
bug frontend sev-5
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
-
core good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
-
b4b code health next
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
ESCOMP/CTSM#4330 · 1 comentario ·
Los mantenedores suelen responder en 1 día