GFQL Cypher: numeric operator conformance + expression-lane typing (round-004 umbrella)

Abierto
  • ¿Algo no está bien?
#1,900 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
pandas, python
Área
backend, data

Línea de trabajo

Start with the probe report in scratchpad probe-expr/ and the cited comments in lazy/engine/polars/row_pipeline.py:90 and row_pipeline.py:1353; compare the column arithmetic path with literal constant-folding behavior. The issue lists several independent conformance gaps and leaves one behavior awaiting a decision, so first confirm which finding is in scope. Done means the selected behavior matches the stated openCypher expectation and is covered by probes for both engines.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Round-004 expression/predicate probe (~85 hand-oracled queries × both engines @ d044e3e84). Headline: TVL/null core is FULLY conformant (full AND/OR/XOR truth table, IN-list nulls, string predicates, ORDER BY null placement); debt concentrates in numerics — findings 1-3 share one root: column arithmetic lowers to raw pandas/polars ops without the Cypher numeric-tower wrap the const-folder applies to literals.

SILENT-WRONG (both engines):

  1. Modulo is Python-floored, openCypher is truncated: -7 % 3 → 2 (oc -1); column path identical; breadcrumb comment at lazy/engine/polars/row_pipeline.py:90 confirms the known gap.
  2. Column int division is true-division: n.rank / 2 (int64) → floats; literal 5 / 2 → 2 correctly (const-folder toInteger wrap) — only the column lane skips it.
  3. Column int div-by-zero → inf silently; openCypher mandates error.
  4. Simple CASE WHEN null matches null subjects (deliberate per row/pipeline.py:1353 comment, but contradicts openCypher/Neo4j: simple CASE uses '=', null never matches).
  5. bool-vs-int comparison coerces (WHERE n.flag > 0 matches) instead of null semantics; the numeric-vs-string guard exists but bool-vs-int slips past.

Typed gaps / form defects: missing property in WHERE is GFQLSchemaError (makes IS NULL unusable for schema-optional props; RETURN n.absent correctly nulls); ORDER BY restricted to projected columns; col-vs-col STARTS WITH raises RAW ValueError (untyped); 1 + null pandas typed-errors while polars correctly nulls (parity broken in the conforming direction); toInteger('x1') errors vs null; select-lane errors all mislabeled invalid-node-reference. Entity fns labels()/properties() return display strings not structured values.

Swept clean: extensive TVL/string/CASE/ORDER-BY/SKIP-LIMIT inventory in probe report (scratchpad probe-expr/). Fix order: 1-3 (one numeric-tower root) → 5 → 4 (needs decision: keep documented deviation or conform) → error-typing polish.

Lenguaje dominante
Python
Estrellas
2.6k
Forks
229
Merge medio
1 d 5 h
PR fusionados (30 d)
99

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de graphistry/pygraphistry

Todos los issues de graphistry/pygraphistry

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.