Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

[Feature Request] Fix the tflint recommended preset findings and enforce the full preset

Abierto
  • ¿Algo no está bien?
#321 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
terraform
Área
devops, infrastructure

Línea de trabajo

Start with .tflint.hcl and tools/tflint.sh, then run tflint to reproduce the 66 findings and the evaluation failure in blueprints/fedramp-high/cloud-scheduler-job. Work through the reported unused declarations, deprecated interpolations, and untyped variable, recording notes for removed variables that may still appear in tfvars files. Done when the preset reports no findings, the blueprint loads successfully, and the script enforces the full preset.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Enhancement Level of Effort - Medium Priority - Medium Scope - Blueprint Scope - Fast Scope - Module

Feature Description

Fix the findings that the tflint recommended preset reports today, then let tools/tflint.sh enforce the whole preset instead of only the terraform_naming_convention rule.

Use Case

  • The .tflint.hcl file enables the recommended preset, but CI never ran tflint until #310, so findings accumulated.
  • On main, the preset reports 66 findings: 62 terraform_unused_declarations, 3 terraform_deprecated_interpolation and 1 terraform_typed_variables.
  • tflint also fails to load blueprints/fedramp-high/cloud-scheduler-job, because it evaluates base64encode(var.data) with a null default.

Proposed Solution

  • Remove or use the unused variables and locals, convert the deprecated interpolations, and type the remaining variable.
  • Fix the cloud-scheduler-job evaluation, for example by guarding the null value.
  • Drop --only=terraform_naming_convention from tools/tflint.sh once the findings reach zero.
  • Removing an unused variable breaks tfvars files that still set it, so each removal needs a note.

Compliance & Deployment Context

  • Target Deployment Type(s):
    • US Region Restricted (e.g., Access Policy constraint)
    • FedRAMP Moderate
    • FedRAMP High
    • DoD IL4
    • DoD IL5
    • All / General
  • Relevant NIST 800-53r5 Controls: CM-2 baseline configuration

Reusability Check

Stellar Engine prioritizes reusability.

  • I have checked if this functionality can be achieved by extending an existing module or blueprint.
  • I have verified that this does not duplicate existing functionality.

Alternatives Considered

  • Disable the noisy rules in .tflint.hcl, which hides real dead code.
  • Keep only the naming rule, which leaves the preset unenforced.

Additional Context

  • Related: #309, #310 and #311.
Lenguaje dominante
HCL
Estrellas
55
Forks
21
Merge medio
1 d 19 h
PR fusionados (30 d)
53

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de google/stellar-engine

Todos los issues de google/stellar-engine

Issues similares

Más issues de DevOps

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.