AE: Sharjah sub-key has a shadda on the teh marbuta (إمارة الشارقةّ)
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 64/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- cpp
- Área
- localization
Línea de trabajo
Inspect the AE record and compare its sub_keys and sub_names with the live endpoint, then read region_data_builder.cc to see how the key and display name are consumed. Done means the Sharjah data no longer contains the misplaced mark, the key and name remain aligned, and the corrected record is reflected by the endpoint.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
In the AE (United Arab Emirates) data, the sub-key for Sharjah carries an ARABIC SHADDA (U+0651) on a letter that cannot take one.
Fetched from the live endpoint just now:
https://chromium-i18n.appspot.com/ssl-aggregate-address/data/AE
-> https://www.gstatic.com/chrome/autofill/libaddressinput/chromium-i18n/ssl-aggregate-address/data/AE
"sub_keys": "أبو ظبي~إمارة الشارقةّ~الفجيرة~ام القيوين~إمارة دبيّ~إمارة رأس الخيمة~عجمان",
"sub_names": "أبو ظبي~الشارقة~الفجيرة~ام القيوين~دبي~رأس الخيمة~عجمان",
The problem
The Sharjah key ends ... U+0642 U+0629 U+0651, i.e. a shadda placed after the teh marbuta ة:
key إمارة الشارقةّ U+0625 U+0645 U+0627 U+0631 U+0629 U+0020
U+0627 U+0644 U+0634 U+0627 U+0631 U+0642 U+0629 U+0651
name الشارقة U+0627 U+0644 U+0634 U+0627 U+0631 U+0642 U+0629
A shadda marks gemination of a consonant. Teh marbuta is a word-final letter representing the feminine ending, and it is not geminated in this name — it cannot carry a shadda. In الشارقة the gemination is on the sheen ش, by sun-letter assimilation after the definite article ال. If the name is written with the shadda at all, the correct position is:
الشّارقة U+0627 U+0644 U+0634 U+0651 U+0627 U+0631 U+0642 U+0629
^ shadda on the sheen
This is also what the standard romanization "Ash Shāriqah" reflects — the doubled Sh.
Why I think it is a slip rather than a convention
The same file spells Dubai's shadda correctly: إمارة دبيّ, where the final yaa genuinely is geminated (دُبَيّ). So the data can and does place a shadda correctly one field away. Sharjah is the odd one out, not the result of a consistent policy.
User-visible effect
name is the clean الشارقة while key carries the mark, and in region_data_builder.cc the sub-region is added as AddSubRegion(key, name). So a dropdown displays الشارقة while the value that is stored and printed on the label is إمارة الشارقةّ. The user cannot see the anomaly in order to correct it.
It also means the natural spelling does not validate — an address submitting الشارقة or إمارة الشارقة does not match the key.
Two smaller things in the same record
- The
إمارة("Emirate of") prefix is applied to only 3 of the 7 keys — Sharjah, Dubai and Ras al Khaimah have it; Abu Dhabi, Fujairah, Umm Al Quwain and Ajman do not. ام القيوينis missing the hamza; the usual spelling isأم القيوين.
Note on provenance
I am fairly sure this form is inherited from the ISO 3166-2 table rather than authored here, so this is a report that the upstream source has it wrong, not a claim that it originated in this project. I mention it because #244 says reporting data issues here is the right route for server-side updates.
I have not verified whether the other RTL-script countries have the same class of issue; I only checked that across the aggregate data the AE entries were the ones where a key and its own name differ by a combining mark.
- Lenguaje dominante
- C++
- Estrellas
- 629
- Forks
- 109
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de google/libaddressinput
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
google/libaddressinput#255 ·
-
Improve Spain postcode regexAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
google/libaddressinput#245 · 1 comentario ·
-
Error in Spain sub_zip listAbierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 52/100
google/libaddressinput#250 · 2 comentarios ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 58/100
google/libaddressinput#249 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 45/100
google/libaddressinput#244 · 2 comentarios ·
Todos los issues de google/libaddressinput
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
godotengine/godot#124252 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 Menos de una hora Aptitud para principiantes 66/100
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Los mantenedores suelen responder en 1 día
-
lldb
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
llvm/llvm-project#229592 · 11 comentarios ·
Los mantenedores suelen responder en 1 día