Clarify that pull_request_review_write create without event creates a pending review

Abierto Apto para principiantes
#2,524 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
1/5
Tiempo estimado
Menos de una hora
Aptitud para principiantes
72/100
Tipo de issue
Documentación
Claridad
Bien especificado
Estado de actividad
Tranquilo
Stack tecnológico
go

Línea de trabajo

Busca pull_request_review_write en la definición de la herramienta e inspecciona su anotación de título y su descripción breve. Actualiza la redacción visible para el usuario de modo que method: "create" sin event signifique claramente una revisión pendiente y no enviada; el comportamiento existente de herramienta única debe permanecer sin cambios.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

request ai review

Problem

When using the pull_request_review_write tool from a client like Claude Code to "create a review," the server correctly creates a pending review if the event parameter is omitted. However, the user-facing title/description does not clearly indicate that this call only creates a pending review and does not submit it.

Current behavior
  • Tool name: pull_request_review_write
  • Title: "Write operations (create, submit, delete) on pull request reviews"
  • Description (in code) already says:

    create: Create a new review of a pull request. If "event" parameter is provided, the review is submitted. If "event" is omitted, a pending review is created.

Clients often show only the short title or a condensed description, so users just see that a review is being "created," not that it's pending only.

This is confusing when watching MCP tool calls in the UI: the first call to pull_request_review_write looks like it "created a review," but in GitHub it is actually just opening a pending review, which then gets line comments via add_comment_to_pending_review, and later is submitted with pull_request_review_write method: "submit_pending".

The underlying workflow is correct; the wording is misleading.

Requested change (minimal, backwards compatible)

Update the Title annotation for pull_request_review_write to make "pending" explicit, e.g.:

  • "Create pending / submit / delete pull request reviews", or
  • "Pending review create / submit / delete for pull requests"

Optionally, emphasize in the short description that method: "create" without event creates a pending review and does not submit it.

This keeps the existing single-tool design (no new tools, no API change) but makes the behavior much clearer to users of MCP clients that only surface the short title/description.

Lenguaje dominante
Go
Estrellas
33.1k
Forks
5k
Merge medio
2 d 15 h
PR fusionados (30 d)
27

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de github/github-mcp-server

Todos los issues de github/github-mcp-server

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.