[go-fan] Go Module Review: testify

Cerrado Apto para principiantes
  • ¿Algo no está bien?
#74,450 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
1/5
Tiempo estimado
Menos de una hora
Aptitud para principiantes
65/100
Tipo de issue
Documentación
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go
Área
documentation

Línea de trabajo

El único cambio propuesto es una edición del estado en docs/adr/47252-testify-error-assertion-conventions.md, que actualmente dice Status: Draft. Abre ese archivo y comprueba que la migración que describe coincide con la configuración de testifylint en .golangci.yml antes de cambiar la línea de estado a Accepted. Está terminado cuando el ADR dice Accepted y nada más en el documento cambia.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

automation cookie
Module Overview

github.com/stretchr/testify is Go's most widely used test-tooling library, providing assert/require for fluent assertions plus optional mock/suite packages. It's permanently frozen at v1 (no v2 planned — discussion #1560).

Current Usage in gh-aw
  • Files: require imported in 1362 _test.go files; assert in 1284 _test.go files — test-only, as expected (no production code imports it).
  • Call volume: ~26,575 assert.* calls, ~26,811 require.* calls.
  • Key APIs: Equal (12,825), NoError (15,111), ErrorContains/ErrorIs/EqualError (1,874 across 510 files), InDelta/JSONEq/YAMLEq (609 across 152 files), Eventually/EventuallyWithT/CollectT (13 across 7 files).
  • Not used: mock, suite — zero imports. Given t.Parallel() appears 4,714 times across 693 files, and testify's own README flags suite as unsupported for parallel tests (#934), skipping suite here is correct.
Research Findings

Current version in go.mod (v1.12.1) already matches the latest upstream release.

Recent Updates

v1.12.1 (2026-08-19) swapped testify's internal YAML dependency from the old gopkg.in/yaml.v3 fork to go.yaml.in/yaml/v3, shrinking testify's own dependency footprint to just go.yaml.in/yaml/v3 and the dependency-free stretchr/objx. No breaking changes — v1 is frozen; all improvements land as additive minor releases.

Best Practices

Maintainers recommend testifylint (via golangci-lint) to catch common misuse.

Improvement Opportunities

🏃 Quick Wins

.golangci.yml already enables testifylint with enable-all: true — the strictest setting, matching upstream's own recommendation. One loose end: docs/adr/47252-testify-error-assertion-conventions.md documents the ErrorContains/require.* migration (already merged and enforced by that lint rule, confirmed live with 1,874 ErrorContains/ErrorIs/EqualError call sites) but is still marked Status: Draft. Since the enforcement is live in CI and the described migration already landed, this ADR should be moved to Accepted.

✨ Feature Opportunities

None identified as required — the project already tracks testify's own recommended linter config at its strictest setting.

📐 Best Practice Alignment

Already strong across the board:

  • testifylint enable-all: true is live.
  • ErrorContains is used instead of the panic-prone assert.Contains(t, err.Error(), ...) pattern (eliminates nil-deref crashes on a nil err).
  • mock/suite are correctly avoided in favor of real fixtures and parallel subtests, which fits this codebase's heavy use of t.Parallel().
🔧 General Improvements

No further action identified beyond finalizing the ADR status above — testify usage here is mature and already follows upstream guidance closely.

Recommendations

  1. Move docs/adr/47252-testify-error-assertion-conventions.md from Status: Draft to Status: Accepted — the migration it describes is already merged and enforced by CI lint.

Next Steps

  • Finalize ADR-47252's status.
  • No dependency action needed; testify is already pinned to the latest release.

Generated by Go Fan
Module summary saved to: scratchpad/mods/testify.md

Generated by 🐹 Go Fan · claude · agent · ~80 AIC · ⌖ ~1 AIC · ⊞ 4.5K · ◷

  • expires on Nov 4, 2026, 12:07 AM UTC-08:00
Lenguaje dominante
Go
Estrellas
5.6k
Forks
615
Merge medio
5 h 36 min
PR fusionados (30 d)
805

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de github/gh-aw

Todos los issues de github/gh-aw

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.