upload-sarif: `git call failed.` more times than necessary for a working directory without a git repository

Abierto
#3,383 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
typescript
Área
ci-cd

Línea de trabajo

Comienza en src/git-utils.ts en la línea referenciada y compara su comportamiento con el registro de workflow enlazado. Rastrea por qué la ausencia de un repositorio provoca llamadas repetidas a git durante upload-sarif y, después, verifica que la acción siga subiendo SARIF correctamente sin realizar repetidamente esas llamadas cuando no hay ningún repositorio checkoutado.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

https://github.com/github/codeql-action/blob/f67ec12472e1b361f5e1e2085f5e6f85a57e3cd6/src/git-utils.ts#L87

https://github.com/check-spelling-sandbox/skipper/actions/runs/20649925837/job/59292941788

Run github/codeql-action/upload-sarif@7434149006143a4d75b82a2f411ef15b03ccc2d7
git call failed. Continuing with commit SHA from user input or environment. Error: The checkout path provided to the action does not appear to be a git repository.
Uploading code scanning results
  Processing sarif files: ["cifuzz-sarif/results.sarif"]
  Validating cifuzz-sarif/results.sarif
  Adding fingerprints to SARIF file. See https://docs.github.com/en/enterprise-cloud@latest/code-security/code-scanning/integrating-with-code-scanning/sarif-support-for-code-scanning#providing-data-to-track-code-scanning-alerts-across-runs for more information.
  (node:12002) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
  (Use `node --trace-deprecation ...` to show where the warning was created)
  git call failed. Continuing with commit SHA from user input or environment. Error: The checkout path provided to the action does not appear to be a git repository.
  git call failed. Continuing with commit SHA from user input or environment. Error: The checkout path provided to the action does not appear to be a git repository.
  git call failed. Will calculate the base branch SHA on the server. Error: The checkout path provided to the action does not appear to be a git repository.
  Uploading results
  Successfully uploaded results
Waiting for processing to finish
git call failed. Continuing with commit SHA from user input or environment. Error: The checkout path provided to the action does not appear to be a git repository.

Ideally, the action should be able to "quickly" determine that there isn't a repository checked out and not waste additional time running git commands.

Note that this flow (using google/clusterfuzzlite/actions/run_fuzzers and then ideally uploading sarif output) is a flow that people expect to be able to do (yes, Google is missing documentation for how to do it, but...).

Lenguaje dominante
TypeScript
Estrellas
1.6k
Forks
493
Merge medio
1 d 13 h
PR fusionados (30 d)
44

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de github/codeql-action

Todos los issues de github/codeql-action

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.