`startColumn must be greater than or equal to 1` message should report offset for error
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 45/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Estancado
- Stack tecnológico
- github-actions, typescript
- Área
- ci-cd
Línea de trabajo
Comienza con el fallo de validación en upload-lib.js en las líneas 201 y 251; después, sigue cómo upload-sarif-action.js informa de los errores de esquema. Reproduce el fallo de carga de SARIF enlazado e identifica dónde se pueden mostrar el desplazamiento problemático y el contenido circundante. Se considera terminado cuando los valores no válidos de startColumn y endColumn producen detalles de ubicación prácticos en lugar de solo el mensaje de restricción mínima.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
This run generated a not particularly helpful message:
https://github.com/check-spelling/gnu-gnulib/actions/runs/5151289440/jobs/9276309000#step:2:15096
Uploading results
Processing sarif files: ["/tmp/tmp.Ba0HZNhBK7.sarif.json"]
Error details: instance.runs[0].results[0].locations[0].physicalLocation.region.startColumn must be greater than or equal to 1
{
"path": [
"runs",
0,
"results",
0,
"locations",
0,
"physicalLocation",
"region",
"startColumn"
],
"property": "instance.runs[0].results[0].locations[0].physicalLocation.region.startColumn",
"message": "must be greater than or equal to 1",
"schema": {
"description": "The column number of the first character in the region.",
"type": "integer",
"minimum": 1
},
"instance": 0,
"name": "minimum",
"argument": 1,
"stack": "instance.runs[0].results[0].locations[0].physicalLocation.region.startColumn must be greater than or equal to 1"
}
Error details: instance.runs[0].results[0].locations[0].physicalLocation.region.endColumn must be greater than or equal to 1
{
"path": [
"runs",
0,
"results",
0,
"locations",
0,
"physicalLocation",
"region",
"endColumn"
],
"property": "instance.runs[0].results[0].locations[0].physicalLocation.region.endColumn",
"message": "must be greater than or equal to 1",
"schema": {
"description": "The column number of the character following the end of the region.",
"type": "integer",
"minimum": 1
},
"instance": 0,
"name": "minimum",
"argument": 1,
"stack": "instance.runs[0].results[0].locations[0].physicalLocation.region.endColumn must be greater than or equal to 1"
}
Error: Unable to upload "/tmp/tmp.Ba0HZNhBK7.sarif.json" as it is not valid SARIF:
- instance.runs[0].results[0].locations[0].physicalLocation.region.startColumn must be greater than or equal to 1
- instance.runs[0].results[0].locations[0].physicalLocation.region.endColumn must be greater than or equal to 1
Error: Unable to upload "/tmp/tmp.Ba0HZNhBK7.sarif.json" as it is not valid SARIF:
- instance.runs[0].results[0].locations[0].physicalLocation.region.startColumn must be greater than or equal to 1
- instance.runs[0].results[0].locations[0].physicalLocation.region.endColumn must be greater than or equal to 1
at validateSarifFileSchema (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-lib.js:201:15)
at uploadFiles (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-lib.js:251:9)
at Object.uploadFromActions (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-lib.js:137:18)
at async run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:48:30)
at async runWrapper (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:70:9)
The json is available here: https://github.com/check-spelling/gnu-gnulib/suites/13318061458/artifacts/727508547
Ideally when reporting issues, at a minimum, a line / character offset should be reported, and unless there's a risk of binary output breaking things, a substring showing the offending content in context would be appreciated. (I'm sure I can find the item(s), but I shouldn't have to search through an 850k file to find the problem.
Fwiw, here's the relevant snippet, and it'd be really much nicer if I didn't have to try to search for it (especially because I can't actually search for startColumn:0, I have to remember to search for startColumn":0 -- and if I'm less familiar w/ the json -- which anyone other than me would be -- then I wouldn't know if I need to consider optional whitespace..).
[{"ruleIndex":0,"ruleId":"bad-regex","message":{"text":"Bad regex. \\(bad-regex\\)"},"locations":[{"physicalLocation":{"artifactLocation":{"uri":".github/actions/spelling/patterns.txt","uriBaseId":"%SRCROOT%"},"region":{"startLine":89,"startColumn":0,"endColumn":0}}}]}]
- Lenguaje dominante
- TypeScript
- Estrellas
- 1.6k
- Forks
- 493
- Merge medio
- 1 d 13 h
- PR fusionados (30 d)
- 44
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de github/codeql-action
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
github/codeql-action#4052 · 4 comentarios ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
github/codeql-action#4078 · 1 comentario ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
github/codeql-action#4008 · 9 comentarios ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
github/codeql-action#3978 · 4 comentarios · 1 reacción ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
github/codeql-action#3915 · 6 comentarios · 3 reacciones ·
Todos los issues de github/codeql-action
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
safetrustcr/dApp-SafeTrust#426 ·
-
area:workflow bug ready-for-agent
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
fil-donadoni/tolaria#4409 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Fission-AI/OpenSpec#1960 ·
-
Add dependabot Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
corsairdev/corsair#1764 ·