Switch 2 Pro Controller over USB: turn on SDL's HIDAPI libusb backend

Abierto Apto para principiantes
  • ¿Algo no está bien?
#522 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
74/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
cmake
Área
build-system

Línea de trabajo

Empieza por runtime/cmake/gfx_deps.cmake y las opciones de SDL cerca de set(SDL_VENDOR_INFO ...); el issue especifica las tres opciones que se deben habilitar antes de FetchContent_MakeAvailable(...). Comprueba cómo la configuración proporciona los encabezados y la biblioteca de importación de libusb 1.0, y cómo make-release.ps1 recopila los archivos de ejecución. El trabajo estará terminado cuando la compilación de Windows detecte el controlador conectado por USB y el paquete de lanzamiento incluya la DLL y la licencia de libusb requeridas.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement
What you would like

On Windows, a Switch 2 Pro Controller (USB 057e:2069) connected by USB cable is not picked up. SDL 3.4.18 already has a driver for it (SDL_hidapi_switch2.c), but on Windows it reaches the controller through its libusb path, and that path is off in Recompia's SDL build.

Turning it on works. Add three lines to runtime/cmake/gfx_deps.cmake. Anywhere among the other SDL options works, as long as they come before FetchContent_MakeAvailable(...). We put them after set(SDL_VENDOR_INFO ...):

set(SDL_HIDAPI ON CACHE BOOL "" FORCE)
set(SDL_HIDAPI_LIBUSB ON CACHE BOOL "" FORCE)
set(SDL_HIDAPI_LIBUSB_SHARED ON CACHE BOOL "" FORCE)

The configure step also needs libusb 1.0 headers and an import library (LibUSB_INCLUDE_PATH, LibUSB_LIBRARY), and libusb-1.0.dll goes next to pkp.exe. With _SHARED, SDL loads libusb-1.0.dll at run time, so pkp_rt.dll's import table stays the same as today.

We rebuilt pkp_rt.dll from v0.10.3 with only these lines and libusb 1.0.30, then did the same with v0.10.4-beta.1. On Windows 11, with the Switch 2 Pro Controller connected by USB cable and Steam closed:

  • With the change, on both: gamepad 4 added: "Nintendo Switch Pro Controller" kind=Switch rumble=1 gyro=1. Switch button prompts show and the controls work. The beta's new capabilities line also shows gamepad 4 caps: type=7 real_type=7 vid=057e pid=2069 ....
  • With v0.10.4-beta.1's own release pkp_rt.dll, same PC and controller: no gamepad ... added line, and the prompts stay on keyboard.
Anything else

The release package would need libusb-1.0.dll and its licence (LGPL-2.1). make-release.ps1 takes files like that from the base package, so packaging is your call. This covers USB only, not Bluetooth.

Recommended as a precaution: ship libusb-1.0.dll in the same folder as pkp.exe rather than leaving it to the player's system. SDL loads it by name only (LoadLibraryW("libusb-1.0.dll")), so Windows looks next to the exe first, then the system folders, then PATH. Without a bundled copy, another program's libusb-1.0.dll on PATH could get loaded instead.

This change and its testing were done with the help of Claude (the AI assistant); the build and controller tests were run on real hardware.

Before you send
  • I searched the open and closed issues and this is not already requested.
Lenguaje dominante
C++
Estrellas
224
Forks
0
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de featureJosh/Recompia

Todos los issues de featureJosh/Recompia

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.