Proper native 4:3 support, not a squeezed 16:9 picture

Abierto
  • ¿Algo no está bien?
#418 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
30/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp
Área
frontend

Línea de trabajo

Read pkp_aspect.cpp and the experimental #413 ([pkp] fix_4x3) changes first to understand the existing aspect-ratio handling. Try the fix on a native 4:3 or 16:10 display, then inspect menus, text, HUD, textured backdrops, talking scenes, and studio logo screens. Done means the game lays out and renders these elements correctly at narrower aspects; report your window size, [display] aspect, observations, screenshots, and pkp.log.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Goal: proper native 4:3 support (and other screens narrower than 16:9). The game should render natively at the screen's aspect, with the 3D view, the UI layout and the game's elements adjusted to it, instead of the 16:9 picture being squeezed or stretched into it.

What exists

  • The 3D view is taller on a narrower picture (pkp_aspect.cpp), and the UI layout camera is given the display's aspect (hook_ui_camera).
  • #413 ([pkp] fix_4x3, experimental, off by default): UI panels that fill the whole 1920x1080 canvas (backdrops, fades, dim panels) are scaled to cover the whole picture. Menus, text and buttons are not canvas-sized and stay where they are.

What is still to do

  • Menus, text and the HUD are still a 16:9 layout centred on the canvas: they are not laid out for the taller canvas or anchored to its edges.
  • Textured backdrops (the title photo, the language menu's pattern) stretch if scaled; they need a filler or a re-layout.
  • The letterboxed talking scenes: unconfirmed whether they are canvas-sized panes.
  • The studio logo screens are most likely a 16:9 video.

Help wanted

If you have a native 4:3 or 16:10 screen, try the 4:3 Fix option (Settings > Testing on the Testing channel, or [pkp] fix_4x3 = 1) and send your pkp.log with your window size, [display] aspect, and what looked wrong (a screenshot of each screen helps).

Lenguaje dominante
C++
Estrellas
224
Forks
0
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de featureJosh/Recompia

Todos los issues de featureJosh/Recompia

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.