Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

SCRIP-METRIC-004: validate derived source units before repinning public gallery

Cerrado
  • ¿Algo no está bien?
#286 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@andy-zen-dev ya está trabajando en esto.

Desde el 22/10/2026.

  • #288 de @andy-zen-dev — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
github-actions, json, python
Área
backend, data, testing

Línea de trabajo

Read scriptorium/full_work_gallery.py, the current metric schema, and the pinned Beketova source JSON on fresh master; check whether #278 has already implemented and validated this behavior before starting. Add repin-aware negative tests showing that swapped unit values fail even when source bytes and their Git blob hash change, while preserving the ten-row declaration and Grin diagnostic rows. Run the full canonical tests and installed gallery CI; done means those pass and the stated chart, source identity, M2, and translation boundaries remain intact.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Latent contract mismatch in pinned full-work gallery

In the merged scriptorium/full_work_gallery.py (source blob e3d94d8c8290f8954325a28206aeb416a770a13a) the renderer declares display units for ten supported metrics but does not independently verify the unit field in a newly approved Beketova derived JSON. The two current pinned Git blobs are correct: local audit of source units was 10/10. The issue is a future-repin integrity regression: changing source data plus its reviewed hash could leave unit: ratio displayed as %.

Existing staged handoff, not yet published

/mnt/data/Scriptorium-Gallery-Unit-Contract-20261021.zip (local archive provided in chat) includes apply_unit_contract.py and 3 repin-aware negative tests. It was prepared for the old #276 head 61a32b6...; now #276 is merged. Its original GitHub update_file was denied, and the handoff's 3/3 smoke tests do not substitute for canonical CI. Do not replay the denied mutation unchanged or switch endpoints to circumvent it.

Acceptance

  • Revalidate against fresh master, existing source JSON and current metric schema; preserve the same ten-row declaration (no second registry).
  • Match Beketova unit to the canonical declared source unit (percent maps to display %, words to display types for unique forms, occurrences/1000_words to the display rate). Grin's diagnostic rows do not have this field and must not be assigned invented source units.
  • Negative tests with deliberately repinned source JSON detect swapped percentage/rate/count units even when the new Git blob hash matches changed bytes.
  • Keep full-work chart/chart units, pinned source identity, M2 0/5 and translation boundaries. Full canonical tests and installed gallery CI must pass before merge.
  • Scope only a later independently selected unit; no duplicate issue if #278 has already implemented and validated this behavior.
Lenguaje dominante
Python
Estrellas
4
Forks
0
Merge medio
1 d 8 h
PR fusionados (30 d)
36

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de drevendev/Scriptorium

Todos los issues de drevendev/Scriptorium

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.