Restart cluster job on task completion
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Necesita aclaración
- Estado de actividad
- Estancado
- Stack tecnológico
- python
- Área
- distributed-systems, hpc
Línea de trabajo
Comienza con la configuración de SLURMCluster y con los ejemplos de WorkerPlugin y client.retire_workers incluidos en el issue. Compara su ciclo de vida de los workers y su comportamiento de balanceo de tareas con el enfoque propuesto de scheduler-plugin. Se considera terminado cuando existe una forma documentada y compatible de retirar o reiniciar workers después de completar las tareas, sin repetir tareas ni comenzar trabajos cerca de walltime.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Use case conditions:
- tasks have large and variable run times
- task executes 3rd party software, such that dask cannot migrate the execution state
- workers have a wall time eg HPC cluster
Current behavior:
Compute is wasted on tasks that cannot finish in remaining walltime, task is restarted from scratch on new worker after worker death.
Originally working with this issue on the forums here
More context:
Task executes a 3rd party software (mine requiring multiple threads, see the issues linked in the above post for examples). Code looks something like the following:
import dask
from dask_jobqueue import SLURMCluster
from distributed import Client
import distributed
import logging
import time
def do_one(x):
worker = distributed.get_worker()
logger = logging.getLogger('worker')
logger.setLevel(logging.INFO)
fh = logging.FileHandler(f'worker_{worker.id}.log', mode='w')
fh.setLevel(logging.INFO)
logger.addHandler(fh)
logger.info(f"I am working on {x}")
# run third party software
# this takes a while but is not very consistent in total time
logger.info(f"I finished {x}")
return f"Input {x} done"
if __name__ =='__main__':
cluster = SLURMCluster(
memory="1g",
walltime='00:30:00',
job_extra_directives=['--nodes=1', '--ntasks-per-node=1'],
cores=1,
processes=1,
worker_extra_args=["--lifetime", "28m", "--lifetime-stagger", "50s"],
job_cpu=6
)
cluster.adapt(minimum=2, maximum=10)
client = Client(cluster)
results = []
for future in distributed.as_completed(client.map(
do_one, list(range(100,132))
)):
result = future.result()
results.append(result)
Result of worker_XXX.log
2022-11-07-12:00:00 INFO I am working on 1
2022-11-07-12:22:00 INFO I finished 1
2022-11-07-12:22:03 INFO I am working on 10
Worker XXX is killed at 12:29 due to walltime. 7 minutes of compute is wasted because the state cannot be changed. Task 10 starts from scratch on a new worker.
Attempts to fix:
Short of figuring out a way to move the execution state, I figure the best strategy is to have each task get a brand new SLURM job, so that no compute is wasted and any task that can finish in the walltime works.
- I tried a worker plugin like so:
class KillerNannyPlugin(distributed.diagnostics.plugin.WorkerPlugin):
"""Better as a nanny plugin but those are not running transitions properly."""
def __init__(self, max_stagger_seconds: float = 5):
self.max_stagger_seconds = max_stagger_seconds
def setup(self, worker):
self.worker = worker
def transition(self, key, start, finish, *args, **kwargs):
if start == 'memory' and finish == 'released':
self.worker.io_loop.call_later(3+random.random() * self.max_stagger_seconds, self.worker.close_gracefully, restart=True)
- This was successful in ensuring each task got its own job, but caused task repeat to be on the order of 100%, defeating the point of saving compute
- Have the client retire the worker that just completed a task when the job is done, like so:
for future in distributed.as_completed(client.map(
do_one, list(range(100,132))
)):
who_has = client.who_has(future)
closing = list(list(who_has.values())[0])
client.retire_workers(closing)
- I also added a small time delay to the worker function such that next tasks did not start (and begin wasting energy) while the client retired the worked.
- This seems to have the desired effect, any consequences of this are not clear to me as I observe that tasks are not repeated nor do tasks start on a job that is about to time out.
I think this should be codified somehow as the "solution" above is quite hacky. My intuition says that it would fit best as a scheduler plugin, as using the worker plugin above clearly had adverse effects on task balancing. Happy to help contribute with some input on where this would fit best if it would be a useful addition.
- Lenguaje dominante
- Python
- Estrellas
- 256
- Forks
- 149
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de dask/dask-jobqueue
-
bug LSF
Dificultad 3/5 1-2 días Aptitud para principiantes 65/100
dask/dask-jobqueue#703 · 1 comentario ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
dask/dask-jobqueue#701 ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
dask/dask-jobqueue#699 · 2 comentarios ·
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 38/100
dask/dask-jobqueue#692 · 1 comentario ·
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
dask/dask-jobqueue#691 · 7 comentarios ·
Todos los issues de dask/dask-jobqueue
Issues similares
-
customer-reported
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Azure/azure-cli#34150 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
community-request
Dificultad 1/5 Menos de una hora Aptitud para principiantes 95/100
NVIDIA-NeMo/Curator#2464 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
weblate-discover crashes with an unhandled FileNotFoundError when the directory does not existAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
WeblateOrg/translation-finder#1099 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
trezor/trezor-firmware#7997 ·
Los mantenedores suelen responder en 2 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día