Localisation: own the generator, generate the default strings.xml (19 keys English-only everywhere), migrate ~44 literals, CI gate

Abierto
  • ¿Algo no está bien?
#82 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
android, kotlin, python
Área
ci-cd, localization

Línea de trabajo

Start with the generator that currently lives in Dasher-GTK (Scripts/generate-from-shared.py) and the default values/strings.xml, then compare them with the literals in SettingsScreen.kt, DasherImeService.kt and MainActivity.kt. Done means the default strings file is generated from the catalogue, the hardcoded literals use stringResource, and a CI step fails when the generated output drifts. The issue spans several subsystems, so a newcomer should coordinate with maintainers before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What's missing (from the cross-platform localisation audit, 2026-10-31 — ui-string-audit.md in Dasher-Windows)

Android generates values-*/strings.xml for 33 locales (250 keys each) but three structural gaps leave real user-visible English:

1. The generator doesn't live here

Scripts/generate-from-shared.py lives in Dasher-GTK and writes cross-repo into ../Dasher-Android/app/src/main/res. Vendor it into this repo (with the shared-resources submodule) so Android owns its own pipeline and can CI-gate it.

2. The default values/strings.xml is hand-written, not generated

38 keys maintained by hand while 33 locale files are generated — so 19 of the 35 keys actually referenced in code are English-only in every locale (toolbar_*, settings_title, settings_close, settings_advanced, settings_reset_defaults/done, toolbar_speed, toolbar_auto, share_text, save_default_name, …). Generate the default file from the catalogue's en values and the gap disappears structurally.

3. ~44 distinct hardcoded literals bypass localisation entirely

SettingsScreen.kt (26 — "Privacy-preserving analytics", "App language", "Appearance", "Training data"…), DasherImeService.kt (16 — "Switch to emoji keyboard", "Resize"…), MainActivity.kt (8 — "No game text available", "Copied"…). ~7 are exact catalogue matches (drop-in stringResource swaps: Cancel, Reset, Training data, Reset training data?, Nothing to share, Dasher).

4. No freshness gate — and lint can't catch drift

Nothing regenerates + diffs the strings in CI (Dasher-Windows' build-installer.yml shows the pattern). Lint's MissingTranslation is explicitly disabled (checkReleaseBuilds=false, abortOnError=false) — worth re-enabling once the default file is generated.

Also
  • Submodule pin is behind canonical (misses preparing_dasher, float_needs_permission, and the 70-key chrome set with all its translations from the Windows migration)
  • Gotchas: digit-leading catalogue keys get an s_ prefix in the generator; positional format args (%1$d style); "Loaded N chars"-style strings should become <plurals> on migration
Lenguaje dominante
Kotlin
Estrellas
2
Forks
0
Merge medio
4 h 43 min
PR fusionados (30 d)
8

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de dasher-project/Dasher-Android

Todos los issues de dasher-project/Dasher-Android

Issues similares

Más issues de Kotlin

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.