[BUG] Qdrant metadata content overwrites the indexed document body
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 1/5
- Tiempo estimado
- Menos de una hora
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start at crewai/rag/qdrant/client.py and read _create_point_from_document, which the issue identifies as the shared payload helper for sync and async adds. The issue reports an open linked pull request (#9130) with regression tests already prepared. Done means the stored and returned document body remains the original text while non-conflicting metadata remains available.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Description
Qdrant document metadata containing a content key silently replaces the document text in the stored payload. The embedding is computed from document["content"], but search returns metadata["content"] as the document body. Both add_documents and aadd_documents use the same payload helper.
Reproduction
Reproduced on main at 6bd60b223101a11f7ac675706ff1ebb03314c95d (CrewAI 1.15.35), Windows, Python 3.12.15, qdrant-client 1.14.3. No server, model, or API key is needed:
from crewai.rag.qdrant.client import QdrantClient
from qdrant_client import QdrantClient as SDKClient
from qdrant_client.models import Distance, VectorParams
sdk = SDKClient(location=":memory:")
try:
client = QdrantClient(client=sdk, embedding_function=lambda text: [1.0, 0.0, 0.0])
client.create_collection(
collection_name="content_repro",
vectors_config=VectorParams(size=3, distance=Distance.COSINE),
)
client.add_documents(collection_name="content_repro", documents=[{
"content": "Original document text",
"metadata": {"content": "Metadata text", "source": "example.txt"},
}])
result = client.search(collection_name="content_repro", query="Original document text")[0]
print(result["content"])
assert result["content"] == "Original document text", result
finally:
sdk.close()
Actual: prints Metadata text and fails the assertion. The equivalent async create/add/search sequence returns the same wrong text.
Expected: the canonical document body remains Original document text. Non-conflicting metadata such as source remains available.
Cause and proposed fix
_create_point_from_document builds {"content": doc["content"], **metadata}, so metadata wins on collision. Assigning the reserved payload content field after expanding metadata preserves the document body. This keeps the existing flat payload layout and metadata filtering behavior; it does not introduce a new metadata storage format or recover previously overwritten content.
I checked existing issues and open PRs for this collision and did not find a duplicate. A one-line fix and regression tests for mapping/list metadata and empty/nonempty text are ready. The four new cases fail before the fix; the full Qdrant test module passes (47 tests) after it. Real in-memory sync/async roundtrips were also checked.
AI disclosure
AI-generated contribution: the investigation, reproduction, proposed implementation, tests, and this report were prepared and run with an AI coding assistant at the contributor's request. Please apply the required llm-generated label if my account cannot manage repository labels.
- Lenguaje dominante
- Python
- Estrellas
- 60.6k
- Forks
- 9.1k
- Merge medio
- 1 d 4 h
- PR fusionados (30 d)
- 214
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de crewAIInc/crewAI
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
Los mantenedores suelen responder en 1 día
-
Feature request: GoldenDirectiveTool (harmonic relationship score, full vs cropped reporting)Abiertofeature-request
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
crewAIInc/crewAI#9200 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
[FEATURE] Docs: ApifyActorsTool example with a typed-input ActorPosiblemente ocupada @johnisanerd la tomó hace 1 día. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
crewAIInc/crewAI#9132 · 5 comentarios ·
Los mantenedores suelen responder en 1 día
-
[BUG] Scrape tools reject the documented cookies mapping and drop cookies when the URL is passed at runtimePosiblemente ocupada @Luckyou-d la tomó hace 6 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
[BUG] OpenAI-compatible embedding model alias breaks embedder constructionPosiblemente ocupada @gokay-ai la tomó hace 12 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
crewAIInc/crewAI#8761 · 1 comentario ·
Los mantenedores suelen responder en 1 día
Todos los issues de crewAIInc/crewAI
Issues similares
-
physical
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
antonyrag/ragleap-core#1339 ·
-
enhancement good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
AllenCell/SubCellSeg#5 ·
-
[🐛 Bug]: oidc_authverifier.py strips trailing slash causing "Invalid token: Invalid issuer" errorAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
keephq/keep#6934 · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
bug game: 01008BA02525A000 ios
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
Los mantenedores suelen responder en 1 día
-
needs-triage
Dificultad 1/5 Menos de una hora Aptitud para principiantes 87/100
gke-labs/kube-agents#5501 ·
Los mantenedores suelen responder en 1 día