Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

iOS: a canceled request releases the session lock while its runner command still runs on the device

Abierto
  • ¿Algo no está bien?
#3,383 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@thymikee ya está trabajando en esto.

Desde el 10/10/2026.

  • #3385 de @thymikee — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
22/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
ios, typescript
Área
backend, mobile

Línea de trabajo

Start in src/daemon/request-execution-locks.ts and packages/kernel/src/keyed-lock.ts to see when the session and device locks are released, then in packages/platform-apple/src/runner/runner-exchange.ts where an abandoned charge is marked. Done means a test in which a canceled runner command keeps the session lock until the runner journal reports it terminal, plus the live iOS press-then-relaunch check. Linked PR #3385 is already open against this, so check it before starting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

A per-call signal (#3178) cancels a request, but on iOS the daemon releases the session's lock before the device has finished the canceled work. The next request on the same session can then run while the aborted command is still executing on the device.

  • The per-session and per-device keyed locks are held by the handler's promise (request-execution-locks.ts, keyed-lock.ts).
  • On abort, the runner fetch rejects at once, the exchange marks the charge abandoned and rethrows (runner-exchange.ts), and the handler settles. The lock is released.
  • The runner never sees the disconnect. Its serial commandExecutionQueue runs the command to completion.
  • Only runner commands queue behind it. A next request whose device work skips the runner, such as a simctl launch from open --relaunch, simctl privacy, or a screenshot, can overtake the tap. So can the runner's inline status and uptime.

Android holds the lock until adb returns, so it is serialized already.

Consumer impact: tester-army/e2e cannot adopt signal. It keeps an inflight set of abandoned commands and waits for each response before the next attempt starts, so that a tap from a canceled step cannot land in the retry (packages/mobile/src/surface.ts). With signal, the client's promise rejects immediately, so that wait no longer proves the device finished.

Required behavior

  • A canceled request whose runner command was already sent keeps its session and device locks until the runner reports that command terminal (completed or failed in the command journal), or until the command's own deadline expires. The client still rejects at once with request_canceled.
  • A command that never reached the runner, or one the runner refused, releases at once, as it does today.
  • A drain that hits the deadline leaves the charge abandoned, as today, so the detach/handoff rules keep seeing it.

Done when

  • A test shows that a canceled runner command holds the session lock until the runner journal reports it terminal, and that a second request on the session starts only after that.
  • Live on an iOS simulator: abort a long press (or longpress --duration) through the client, then immediately run open --relaunch. The launch starts after the press finishes, as the request log shows.

Related: #3178 (per-call signal), #2965 (charge settlement by terminal evidence).

Lenguaje dominante
TypeScript
Estrellas
4.9k
Forks
328
Merge medio
12 h 18 min
PR fusionados (30 d)
538

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de callstack/agent-device

Todos los issues de callstack/agent-device

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.