Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

fill: a sensitive value can still come back in an altered form (iOS read-back)

Abierto
  • ¿Algo no está bien?
#3,392 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
swift, typescript
Área
mobile, security

Línea de trabajo

Start with the TEXT_ENTRY_MISMATCH message in RunnerTests+TypeExecution.swift around line 111, which quotes the observed read-back value, and with FillUnconfirmedVerification in packages/contracts/src/fill-evidence.ts, which carries before and after. Check how #3351 redacts the expected and requested values for sensitive fills, then apply the same treatment to observed, before and after. Done means a sensitive fill that fails or settles on a different value returns no read-back text in the error or the response, while the error code and verification status remain. A device run is not required to verify the change, but the design of the placeholder should be agreed first.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Follow-up from #3351, as suggested in review.

#3351 keeps the exact text of a sensitive fill (--text-stdin, --record-as) out of responses and errors. Two places can still carry a changed form of that text, which no literal match catches:

  • Error: the iOS runner's TEXT_ENTRY_MISMATCH message quotes both sides: text entry read-back did not match: expected "…", observed "…" (RunnerTests+TypeExecution.swift:111). expected is the exact value and is now redacted. observed is what the field read back. Per the fill help this error covers dropped characters, so it can be the value with a character or two missing.
  • Success: a fill that settles on a different value returns verification: "unconfirmed" with requested, before and after (FillUnconfirmedVerification in packages/contracts/src/fill-evidence.ts). requested is the exact value, but after can be a formatted form of it, like the help's "00 062 91 77" for "000629177".

I found these by reading the code and have not reproduced them on a device, since that needs a field that alters its input.

A possible direction: for a sensitive fill, drop the read-back values instead of matching them. For example, keep the error code with a generic message, and replace before/after with the placeholder. Related: #3261 (the same value in native XCTest logs).

Lenguaje dominante
TypeScript
Estrellas
4.9k
Forks
328
Merge medio
12 h 18 min
PR fusionados (30 d)
561

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de callstack/agent-device

Todos los issues de callstack/agent-device

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.