Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

fix(apple-runner): fence prep spawns after teardown or last-waiter cancellation

Abierto
  • ¿Algo no está bien?
#3,220 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@thymikee ya está trabajando en esto.

Desde el 5/10/2026.

  • #3239 de @thymikee — abierto

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
node.js, typescript
Área
mobile-dev, testing

Línea de trabajo

Start by reading PR #3193 and trace the runner start, preparation-spawn, teardown, and waiter-cancellation paths it changed; the issue does not name source files or tests. Then identify where the session lock is held during close and how retries are admitted. Done means the specified cancellation controls and live close-during-build route show no respawn, close completes, owned children are cleaned up, and the focused tests and affected gate pass.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

needs-triage

Purpose

A runner start must stop creating preparation processes after its execution host is torn down or its last interested waiter cancels. Stopping the currently registered children once is insufficient.

PR #3193 measured this during close with a cold build: close killed the first build-for-testing before obtaining the runner session lock, but the detached prewarm health retry spawned a second build while close waited for that lock. Close reached its timeout; the second build remained until daemon stop. Original evidence: https://github.com/callstack/agent-device/pull/3193#issuecomment-5981188182. This observation is at b6cdd3c49, not a fresh reproduction on main.

Required behavior

  • The in-flight runner start owns whether further preparation is admitted. Device teardown closes that admission before stopping current prep children or waiting for the session lock.
  • Canceling the final interested waiter closes admission for that start. Canceling one waiter must preserve work still needed by another.
  • Check admission at every preparation spawn, including retries after a killed build. A check only when registering an already spawned child is too late.
  • A later independent open may create a fresh start; a retired start cannot resume and publish a runner into it.
  • Prefer one start-owned cancellation/admission mechanism. Reassess whether the request-owner prep filter introduced by #3193 remains necessary once the reachable callers and waiter semantics are covered.

Done when

  • A control holds the runner session lock during a cold build, begins non-retained close, and attempts a retry after the first child is stopped. No second prep child is spawned; close settles without waiting for a replacement build.
  • Controls cover cancellation before the first prep spawn, last-waiter cancellation, and another still-interested waiter.
  • Repeat the live close-during-build route with evidence of no respawn, completed close, and cleanup. Retain the original evidence attribution.
  • Focused tests and the affected gate pass; process signaling remains scoped to owned children.

Depends on #3193. This is start admission, not another host-wide timeout sweep or a shorter join timeout.

Lenguaje dominante
TypeScript
Estrellas
4.8k
Forks
315
Merge medio
11 h 37 min
PR fusionados (30 d)
556

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de callstack/agent-device

Todos los issues de callstack/agent-device

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.