Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Harden dumpDebugLoc against malformed .debug_loc sections

Abierto
  • ¿Algo no está bien?
#9,249 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
cpp, wasm
Área
compilers

Línea de trabajo

Start in dumpDebugLoc in third_party/llvm-project/dwarf2yaml.cpp, where the exit(1) on a null list sits, and read parseOneLocationList to see how entry.Loc is sized before the copy. Check how the address size is taken from the first CU. Done means a malformed list prints a warning and skips the rest of the section instead of exiting, the entry.Loc length is bounded, and a debug-build assert covers the shared address size. The issue does not give the length limit, so that needs a maintainer decision.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Background:

#6879 was a SIGSEGV in dumpDebugLoc for modules with empty .debug_loc
sections. Fixed by #7910 with a null-CU guard. While reviewing that fix,
three defensive improvements to the same function became apparent. None
is a regression, but each turns a malformed-input case into a hard
failure when it could fail gracefully.

Location: third_party/llvm-project/dwarf2yaml.cpp, dumpDebugLoc.

  1. exit(1) on parse failure.

    if (!list) {
  errs() << "debug_loc error\n";
  exit(1);
}

    A single malformed location list aborts the entire wasm-opt run. A
    warning plus break (skip the rest of the section) would let the tool
    finish processing the module with incomplete debug info, which is
    the behavior for every other diagnostic in wasm-opt.

  2. Unbounded copy of location expression bytes.

    entry.Loc is read from the section by parseOneLocationList. There is
    no upper bound on its length before the copy into loc.Location. A
    malformed length field causes unbounded allocation.

  3. Address-size heuristic.

    The comment "should be ok since they all have the same address size?"
    is a heuristic. All CUs in well-formed modules share the same
    AddrSize, so reading it from the first CU is safe in practice, but
    the assumption is not enforced.

Proposed changes:

  • Replace exit(1) with a warning and break.
  • Add a length sanity check before copying entry.Loc.
  • Promote the address-size comment from a question to an explicit
    assumption with a debug-build assert.

Refs #6879, #7910.

Lenguaje dominante
WebAssembly
Estrellas
8.7k
Forks
895
Merge medio
1 d 21 h
PR fusionados (30 d)
95

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de WebAssembly/binaryen

Todos los issues de WebAssembly/binaryen

Issues similares

Más issues de Compilers

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.