AsyncQueuer: concurrency > 1 not honoured for items added while another is executing (regression in 0.22.0)
Los mantenedores suelen responder en 2 días
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 66/100
- Tipo de issue
- Error
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- node.js, typescript
- Área
- backend
Línea de trabajo
Start with the AsyncQueuer addItem path and its private #tick logic, especially the pendingTick guard described in the issue. Run the linked gist with @tanstack/pacer 0.22.0 and 0.21.1 to compare behavior. Done means adding items while an execution is pending fills every available concurrency slot without bypassing wait behavior.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
TanStack Pacer version
@tanstack/pacer v0.22.0 (via @tanstack/react-pacer v0.23.0). Last working version: @tanstack/pacer v0.21.1 (@tanstack/react-pacer v0.22.1).
Framework/Library version
Reproduced with the core package on Node.js v25.9.0 (no framework). Originally seen through useAsyncQueuer with React v19.3.0.
Describe the bug and the steps to reproduce it
Since @tanstack/pacer 0.22.0, an AsyncQueuer with concurrency: 2 runs items one at a time when they are added one after another, for example one addItem() per user click. The second item waits for the first to finish even though a concurrency slot is free. On 0.21.1 both start immediately.
Steps:
- Create an
AsyncQueuerwith{ concurrency: 2, wait: 0 }and a task that stays pending (a long download, say). - Call
addItem("a"), thenaddItem("b"). - Check how many tasks have started.
Expected: 2 started, 2 active, 0 pending (what 0.21.1 does).
Actual on 0.22.0: 1 started, 1 active, 1 pending.
import { AsyncQueuer } from "@tanstack/pacer";
let started = 0;
const queuer = new AsyncQueuer(
async () => {
started++;
await new Promise(() => {}); // a long-running task
},
{ concurrency: 2, wait: 0 },
);
queuer.addItem("a");
queuer.addItem("b");
await new Promise((r) => setTimeout(r, 50));
const { activeItems, items } = queuer.store.state;
console.log({ started, active: activeItems.length, pending: items.length });
@tanstack/pacer |
output |
|---|---|
| 0.21.1 | started=2 active=2 pending=0 |
| 0.22.0 | started=1 active=1 pending=1 |
Likely cause: #246 (the fix for #188) keeps pendingTick: true while executions are in flight (#tick: "pendingTick must stay true while executions or wait timers are pending"), and addItem only calls #tick() when !pendingTick. So an item added during an execution isn't picked up until that execution settles and re-ticks, even though a slot is free. main still has the same guard. The #188 intent (don't bypass wait) seems to need the guard only while a wait timer is armed, not while an execution runs with free slots.
(Investigated with AI assistance. The repro and the version comparison above were run and checked by hand.)
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)
https://gist.github.com/ilyaauditoo/710aab918995470c11960aa9e33ff0f0 — npm install && npm start (pins @tanstack/[email protected]; change it to 0.21.1 to see the expected behaviour).
Screenshots or Videos (Optional)
No response
Do you intend to try to help solve this bug with your own PR?
Yes, I think I know how to fix it and will discuss it in the comments of this issue
Terms & Code of Conduct
- I agree to follow this project's Code of Conduct
- I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
- Lenguaje dominante
- TypeScript
- Estrellas
- 776
- Forks
- 67
- Merge medio
- 1 d 15 h
- PR fusionados (30 d)
- 11
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de TanStack/pacer
-
replace deprecated Vitest spy assertion aliasesPosiblemente ocupada @2yunseong la tomó hace 22 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Los mantenedores suelen responder en 2 días
-
Queued AsyncDebounce execution is silently dropped if it is executed after an in-flight run completesPosiblemente ocupada @SimenB la tomó hace 14 días. Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 75/100
Los mantenedores suelen responder en 2 días
-
Async utilities count swallowed retryer failures as successes and call onSuccess(undefined)Posiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
Los mantenedores suelen responder en 2 días
-
debouncer.getAbortSignal() returns null due to maybeExecuteCount increment mismatchPosiblemente ocupada @SimenB la tomó hace 14 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 35/100
Los mantenedores suelen responder en 2 días
-
with devtools added getting export setStyleProperty was not found in module errorPosiblemente ocupada @restareaByWeezy la tomó hace 212 días. Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
TanStack/pacer#131 · 3 comentarios · 4 reacciones ·
Los mantenedores suelen responder en 2 días
Todos los issues de TanStack/pacer
Issues similares
-
refactor
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
tomnewport/memprot-topo#55 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
WalletConnect/walletconnect-monorepo#7368 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
BU-Spark/se-chem-apll#47 ·
-
embed: handleTurboSignMessage header comment says the signing page posts to '*' (it never does)Abiertodocumentation
Dificultad 2/5 Menos de una hora Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 Medio día Aptitud para principiantes 70/100
udistrital/paginaweb_root#23 ·