Measure chance reach misses in oracle properties

Abierto
  • ¿Algo no está bien?
#2,289 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
53/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
devtools, testing

Línea de trabajo

Start with packages/db/tests/declared-reach-oracle.property.test.ts and docs/contributing/oracle-coverage.md, then find the other files using createOracleReach or runOracleCampaign. Measure normal-budget reach misses across seeds for states not entered by fixed examples; add fixed examples through the shared seam or document probabilistic states with a maintainer decision. Consider whether a lint rule can identify chance-selected reach prefixes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problem

A generated property declares the states its laws depend on, and createOracleReach fails a run in which too few histories entered one (ORC-015). When only random histories enter a declared state, the check can fail by chance at the normal run budget. No law fails, but CI goes red. #2287 was one case: in about 0.3% of 60-run campaigns, source-health.history never chose the one reach prefix that enters two of its states.

The fix for #2287 adds a shared seam for this:

  • oraclePropertyOptions(…, { examples }) runs fixed examples first in every run, on top of the base budget.
  • createOracleReach(…, { fixedHistories }) fails for each declared state that those examples did not enter.

The three source-health properties use the seam, so their reach does not depend on the seed. packages/db/tests/declared-reach-oracle.property.test.ts (oracle.declared-reach) owns these rules.

About 40 other files use createOracleReach or runOracleCampaign. Their chance of a reach miss at the normal budget has not been measured.

Work

  1. For each property with declared reach, list the declared states that no fixed example enters.
  2. Measure how often a normal-budget run misses each of those states. For example, count the misses across many seeds, or sample the generator.
  3. For each state that can miss, add a fixed example through the seam, or record the state as probabilistic in docs/contributing/oracle-coverage.md with a maintainer decision. Raise a run budget only with a maintainer decision, because it adds CI time.
  4. Consider a lint rule that reports a property that chooses a reach prefix by chance (fc.option(fc.constantFrom(...prefixes))) without fixed examples.

The coverage map's "Oracle tooling" section links to this issue as the destination for the gap.

Refs #2234, #2287.

This issue was written by Isaac.

Lenguaje dominante
TypeScript
Estrellas
4k
Forks
277
Merge medio
1 d 7 h
PR fusionados (30 d)
170

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/db

Todos los issues de TanStack/db

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.