Fix linear stairs: orientation, sizing, zero height and step handles

Abierto
  • ¿Algo no está bien?
#191 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp, unity
Área
game-dev

Línea de trabajo

The issue covers the linear stairs generator and the shared rules for all generators; no source files are named, so start by locating the linear stairs generator in the Chisel code and reproducing each problem in the Unity editor. Item 4 needs investigation before any change: find what the second point on one side does. Done means the five listed behaviours are fixed, zero sizes are rejected, and negative sizes build valid shapes. The issue says more problems will surface after these fixes, so expect follow-up work.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Problems with the linear stairs. This needs more iteration: there are more issues, best identified once these are fixed.

  1. Default orientation. The stairs should default to running along the long side.
  2. Sizing down moves the bottom further down. It shouldn't.
  3. Zero height. Zero-height stairs shouldn't be allowed. Vertically inverted stairs can be allowed (though they're probably of limited use).
  4. The two points on one side. One changes where the steps end, before the top becomes flat. What the other one is meant to do isn't clear; find out, and make it do something useful or remove it.
  5. Sizing up past what fits at the current step size. The step size shouldn't change. Instead, the height where the steps start should go up, and that height should be draggable too.

Rule for all generators: negative sizes are allowed, and every generator builds a valid shape from them (swapping sides under the hood, so the brush is the right way out). A zero size is never allowed: creating at zero size cancels, and an existing generator can't be made zero sized.

Related: box (#184), capsule (#185), cylinder (#186), inspector values (#187), hemisphere (#188), sphere (#189), extruded shape (#190), spiral stairs (#192), Fill Down risers (#148, same generator).

Lenguaje dominante
C#
Estrellas
135
Forks
15
Merge medio
22 min
PR fusionados (30 d)
97

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de RadicalCSG/com.chisel

Todos los issues de RadicalCSG/com.chisel

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.