ExecuteTaskActivity retries forever, so a failing step never parks for an admin
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 55/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- go
- Área
- backend, distributed-systems
Línea de trabajo
Start in workflow/workflow.go at handleTaskNode and trace the ExecuteTaskActivity options and the error path that parks a node for an admin. Then inspect dynamic_split.go and other engine activities for the same retry behavior. Done means repeated retryable task start failures eventually surface as an error and park the node, while steps waiting for asynchronous completion are not cut off by a total time limit.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Describe the Bug
ExecuteTaskActivity runs with no retry policy, so a step whose start keeps failing is retried forever and never reaches the admin park.
handleTaskNode (workflow/workflow.go) sets only ActivityID and a one-year StartToCloseTimeout. With no RetryPolicy, Temporal's default applies: unlimited attempts, with the delay between them growing to 100s. A retryable error from the activity, such as a plugin failing in StartTaskStep, is retried indefinitely. The engine parks a node for an admin only when ExecuteActivity(...).Get returns an error (withCategory(ParkCategoryTaskFailure, err)), and that never happens.
This affects both levels: the task's own workflow (task-wf-…, MICRO_WORKFLOW_QUEUE), where the failing step runs, and the parent workflow's TASK node waiting on it.
To Reproduce
- Run a flow with a PAYMENT step while the host's refid config has no issuer for the payment reference format (e.g.
refid.issuers: []). - Reach the payment step.
- The worker logs
Activity error ... Attempt=Nwithrefid: unknown issuerforever. The node stays RUNNING with no last error, the trader sees "Starting Step", and the admin debugger shows nothing to resolve.
Expected Behavior
After a bounded number of attempts the activity fails, the engine parks the node (AWAITING_ADMIN) with the error, and an admin can see it and retry, complete or abort it.
Suggested shape:
- Set a
RetryPolicyon the task activity with aMaximumAttemptscap (a handful), keeping the backoff. - Cap attempts, not total time. The same activity also waits for asynchronous completion (a user submitting a form, an agency responding), which can legitimately take days, so a
ScheduleToCloseTimeoutwould cut off steps that are only waiting. - Check the other activities the engine runs (e.g.
dynamic_split.go) for the same unbounded default.
Additional Context
- Without a cap, a misconfiguration is only visible in the worker logs.
- Related: errors that can never succeed should not be retried at all: #303.
- Seen in nsw-srilanka local testing, 2026-10-12.
- Lenguaje dominante
- Go
- Estrellas
- 6
- Forks
- 8
- Merge medio
- 21 h 36 min
- PR fusionados (30 d)
- 42
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de OpenNSW/core
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Los mantenedores suelen responder en 1 día
-
payment: test fixtures hardcode real gateway names (govpay/lankapay) instead of generic placeholdersAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
nsw-sl cleanup Type/Improvement
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
Los mantenedores suelen responder en 1 día
-
remote: let the host inject a logger, and log with one consistent policyPosiblemente ocupada @mushrafmim la tomó hace 5 días. AbiertoType/Improvement
Dificultad 4/5 3-5 días Aptitud para principiantes 22/100
Los mantenedores suelen responder en 1 día
Todos los issues de OpenNSW/core
Issues similares
-
agent-research-finding chore
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
jordansmall/spindrift#7370 ·
Los mantenedores suelen responder en 1 día
-
☢️ Bug v3
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
The repo's gates check is clean and runs need no swapsPosiblemente ocupada @turbot-agent-fleet la tomó hoy. Abiertoagent:ready
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
turbot/tailpipe#677 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
needs-kind needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 2 días
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
crossplane-contrib/provider-keycloak#806 ·
Los mantenedores suelen responder en 1 día