ExecuteTaskActivity retries forever, so a failing step never parks for an admin

Abierto
#302 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go

Línea de trabajo

Start in workflow/workflow.go at handleTaskNode and trace the ExecuteTaskActivity options and the error path that parks a node for an admin. Then inspect dynamic_split.go and other engine activities for the same retry behavior. Done means repeated retryable task start failures eventually surface as an error and park the node, while steps waiting for asynchronous completion are not cut off by a total time limit.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Type/Bug
Describe the Bug

ExecuteTaskActivity runs with no retry policy, so a step whose start keeps failing is retried forever and never reaches the admin park.

handleTaskNode (workflow/workflow.go) sets only ActivityID and a one-year StartToCloseTimeout. With no RetryPolicy, Temporal's default applies: unlimited attempts, with the delay between them growing to 100s. A retryable error from the activity, such as a plugin failing in StartTaskStep, is retried indefinitely. The engine parks a node for an admin only when ExecuteActivity(...).Get returns an error (withCategory(ParkCategoryTaskFailure, err)), and that never happens.

This affects both levels: the task's own workflow (task-wf-…, MICRO_WORKFLOW_QUEUE), where the failing step runs, and the parent workflow's TASK node waiting on it.

To Reproduce
  1. Run a flow with a PAYMENT step while the host's refid config has no issuer for the payment reference format (e.g. refid.issuers: []).
  2. Reach the payment step.
  3. The worker logs Activity error ... Attempt=N with refid: unknown issuer forever. The node stays RUNNING with no last error, the trader sees "Starting Step", and the admin debugger shows nothing to resolve.
Expected Behavior

After a bounded number of attempts the activity fails, the engine parks the node (AWAITING_ADMIN) with the error, and an admin can see it and retry, complete or abort it.

Suggested shape:

  • Set a RetryPolicy on the task activity with a MaximumAttempts cap (a handful), keeping the backoff.
  • Cap attempts, not total time. The same activity also waits for asynchronous completion (a user submitting a form, an agency responding), which can legitimately take days, so a ScheduleToCloseTimeout would cut off steps that are only waiting.
  • Check the other activities the engine runs (e.g. dynamic_split.go) for the same unbounded default.
Additional Context
  • Without a cap, a misconfiguration is only visible in the worker logs.
  • Related: errors that can never succeed should not be retried at all: #303.
  • Seen in nsw-srilanka local testing, 2026-10-12.
Lenguaje dominante
Go
Estrellas
6
Forks
8
Merge medio
21 h 36 min
PR fusionados (30 d)
42

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de OpenNSW/core

Todos los issues de OpenNSW/core

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.