Efuse programming: port the vendor PG-packet write path (append-only logical-map updates)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 12/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bien especificado
- Estado de actividad
- Tranquilo
- Stack tecnológico
- c
- Área
- embedded-iot
Línea de trabajo
Start with the existing read power sequence in src/jaguar1/EepromManager.cpp and the 8822E OTP path in src/jaguar3/HalJaguar3.cpp; compare them with the vendor write primitives and packet format. Implement the generation-neutral encoder in src/ with pseudo-test coverage before attempting hardware-specific writes. Done means safe dry-run and space accounting, verified packet writes with recovery, and family-specific hardware validation; burns require sacrificial adapters.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Motivation
The vendor drivers ship a full efuse-programming stack (rtw_efuse_map_write → Efuse_PgPacketWrite → efuse_OneByteWrite, exposed as the MP-mode iwpriv efuse_set wmap,...). Devourer is read-only. Mirroring the write path lets us permanently fix MAC/board-option/ID fields on adapters — including resurrecting corrupt-efuse units — without carrying a vendor kernel module around.
Prerequisite: #284 (logical-map override). Its dump + patch grammar is the authoring format, and the RAM-only override is the mandatory pre-burn validation step: dump → edit → run with override → validate on-air → burn.
Write model (mirror of rtw_efuse_map_write)
Efuse is one-way: blank bytes read 0xFF, programming only pulls bits toward 0, nothing is ever erased. "Overwrite" = diff the desired logical map against the current one, encode only the changed 2-byte word-units as new PG packets, append them at the current end of the physical chain (Efuse_GetCurrentSize); later entries shadow earlier ones at materialization time.
Delivery: a dedicated efusetool example (dump / diff / dry-run / burn) — not wired into the demos. Dry-run is the default and prints the exact packet list + physical byte cost vs. remaining budget; burning requires an explicit flag, and MAC/VID/PID regions a second one.
Implementation details / hazards
- The write-mode power sequence is not the read one. Devourer's
EfusePowerSwitch8812A(src/jaguar1/EepromManager.cpp:1322) only implements the read bracket; the vendor write path additionally raises programming voltage (LDO bits +REG_EFUSE_BURN_GNT= 0x69, thebWritebranch). Getting it wrong does not error — it produces silent partial burns. Port verbatim per chip. - Per-generation write primitives diverge. Jaguar1: one-byte protocol on
EFUSE_CTRL0x0030. Jaguar2/3 vendor writes go through HalMAC (halmac_write_efuse), and our HalMAC port is read-only — decide between porting the halmac write entry points vs. raw-register writes with re-derived brackets. 8822E is a third primitive entirely: OTP power-cut + burst bracket, V1 register layout (RDY at bit 29, 11-bit address field) (src/jaguar3/HalJaguar3.cpp:522-573). - 8822E burns must happen pre-
InitWrite— the existing cache comment records that post-bring-up OTP access is unreliable (TX/coex interference).efusetoolon Jaguar3-E is a dedicated cold session, never a live-device operation. - Space accounting is chip-specific and unforgiving. Extended 2-byte headers past section 16 (Jaguar1/2), packed 2-byte headers everywhere on 8822E, and the vendor reserves an OOB-protect tail (
EFUSE_OOB_PROTECT_BYTES) that must never be consumed. Overrun = chain tail lands in reserved space → undefined parse on next boot. badwordenrecovery is mandatory. Vendor verifies each word post-burn and re-programs failed words in a fresh packet; without it a marginal cell silently corrupts the value and wastes the space. Read-back verify + retry from day one.- Interrupted-burn risk is real on USB. The header must precede data (the chain is positional), so an unplug mid-packet leaves a header pointing at 0xFF data and everything after may misparse. No clean mitigation exists: keep burns single-packet-small, re-parse and verify the full chain after each packet, document "don't burn through a flaky hub".
- Port the vendor efuse masks (per-chip protected-byte arrays covering calibration: xtal, thermal baseline, TX-power PG). Without them one typo'd offset permanently spends spare space shadowing a calibration byte.
- Testability without sacrificing hardware: port the vendor's
bPseudoTestidea as a simulated efuse backend so diff→packet→space→extended-header logic runs as headless ctest selftests. Hardware validation still needs a sacrificial adapter — every burn, including successful tests, permanently spends bytes; budget the test plan honestly (a handful of burns per adapter lifetime). - Shared logic placement: the diff→PG-packet encoder is generation-neutral pure code →
src/next toPhyTableLoader; only the byte-read/byte-write/power-bracket primitives live per-HAL.
Scope exclusions
- BT efuse bank (8821A) — out.
- Kestrel families — out.
- PCIe 8821CE: likely works through
RtlAdapter, but theis_usb()power-seq gates need checking before claiming it.
Suggested milestones
- Pseudo-test backend + PG-packet encoder + space accounting in
src/, headless selftests (incl. extended-header and 8822E packed-header encodes). - Jaguar1 write primitive (power bracket + one-byte write + read-back verify), validated on a sacrificial 8812AU: burn one scratch logical byte, cold-cycle, confirm shadowing.
efusetoolUX: dump / diff vs. #284 patch file / dry-run / burn, masks enforced.- Jaguar2, then Jaguar3-8822C, then 8822E primitives — each gated on having a sacrificial adapter of that family.
- Lenguaje dominante
- C
- Estrellas
- 56
- Forks
- 29
- Merge medio
- 3 h 43 min
- PR fusionados (30 d)
- 75
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de OpenIPC/devourer
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
Follow-ups left open by the 8822B fast bandwidth toggle fix (#584)Posiblemente ocupada @josephnef la tomó hoy. Abiertoenhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 42/100
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 12/100
OpenIPC/devourer#579 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 12/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 8/100
Los mantenedores suelen responder en 1 día
Todos los issues de OpenIPC/devourer
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
Needs-Triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
Los mantenedores suelen responder en 2 días
-
issue: bug report
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 2 días
-
cross-platform fix-now
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
Los mantenedores suelen responder en 1 día
-
feature:index kind:crash status:confirmed triaged
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
clice-io/clice#1123 · 1 comentario ·
Los mantenedores suelen responder en 1 día