Rebase #268's Solr performance fixes onto main

Abierto
#284 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
fastapi, python

Línea de trabajo

Start by comparing PR #268 with #231 and the current main branch to identify which observability changes are already covered and which performance changes remain. Review the Solr query and loading code, curie_lookup, and bulk_lookup, then rebase the remaining work and validate it. Done means the listed performance changes are on main and revalidated, ideally with before and after /status?full=true metrics.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

performance

#268 ("Performance and observability improvements based on /status diagnostics") is open against base ci, not main. Its observability half has been superseded by #231, but its performance half is still valuable and currently stranded:

  • docValues=true on curie, types, taxa, clique_identifier_count
  • Force-merge to <=8 segments after loading (the index is read-only afterwards; production was running with 57 segments)
  • Replace the regex prefix filter curie:/MONDO:.*/ with a prefix-wildcard query curie:MONDO\:* plus input sanitisation — the regex form walks the whole term dictionary
  • Bound curie_lookup's Solr rows from a hard-coded 1,000,000 to the number of input CURIEs
  • Module-level shared httpx.AsyncClient via FastAPI lifespan instead of one per request
  • Parallelise bulk_lookup with an asyncio.Semaphore (BULK_LOOKUP_CONCURRENCY), preserving input order

These should be rebased onto main (dropping the parts #231 already covers) and re-validated, ideally with the /status?full=true metrics from #231 as before/after evidence.

Lenguaje dominante
Python
Estrellas
5
Forks
4
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de NCATSTranslator/NameResolution

Todos los issues de NCATSTranslator/NameResolution

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.