Bound the total number of Solr queries the API has in flight across concurrent requests
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Necesita aclaración
- Estado de actividad
- Activo
- Stack tecnológico
- python
- Área
- api, backend, performance
Línea de trabajo
Start with api/server.py and Config.solr_max_concurrent_lookups, then review the shared httpx client and connection limits introduced by #310. Use the Solr capacity benchmark in TranslatorSRI/babel-validation#107 and the timing work in #309 to guide decisions about the process-wide limit, fairness, and overload behavior. Done means Solr concurrency is bounded across endpoints and concurrent requests, with queueing or rejection behavior and its timeout outcomes covered.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Nothing bounds how many Solr queries the NameRes API process has in flight in total.
SOLR_MAX_CONCURRENT_LOOKUPS(default 100) is a semaphore per/bulk-lookuprequest (Config.solr_max_concurrent_lookupsinapi/server.py). Its comment notes that the service-wide total is that limit multiplied by the number of bulk requests being served at once, and that the default of 100 "should be revisited once we know the real request rate", pointing at TranslatorSRI/babel-validation#107./lookup,/synonymsand the rest have no limit at all.- #310 replaces the per-query httpx clients with one shared client per event loop. It deliberately leaves that client's pool uncapped (
httpx.Limits(max_connections=None, ...)) to keep today's behaviour. A cap below what/bulk-lookupcan have in flight would make queries wait for a pool slot insideSOLR_TIMEOUT_SECONDS, so a busy pool would show up as Solr timeouts.
So a few concurrent large bulk requests, or a burst of autocomplete traffic, can put hundreds of queries on Solr at once. #306 (six concurrent lookups for "vitamin a", each blocked on Solr for 4-5 minutes) may be this or something else, but nothing in the API stops a pile-up like it.
Questions to settle:
- Where the bound lives. A process-wide semaphore around every Solr request, a capped httpx pool, or both. With a capped pool, the wait for a connection needs its own timeout (httpx's
pooltimeout), separate from Solr's, so thatrecent_queriescan tell "NameRes queued it" apart from "Solr was slow". That probably means another outcome alongsidetimeouts. - Fairness. Whether one
/bulk-lookupcan take every slot, starving/lookup(interactive autocomplete), or whether bulk gets a share. - The number. It should come from Solr's capacity under the measured request mix (babel-validation#107's benchmark), not a guess. It also needs dividing by the number of API replicas, since each replica has its own limit.
- What callers see when it's full: queueing, or a fast 503 with
Retry-After.
Related: #309 (timing /bulk-lookup, which would show how long bulk strings wait for a slot).
- Lenguaje dominante
- Python
- Estrellas
- 5
- Forks
- 4
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Sin guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de NCATSTranslator/NameResolution
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
-
Dificultad 4/5 3-5 días Aptitud para principiantes 43/100
-
Dificultad 3/5 1-2 días Aptitud para principiantes 66/100
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
Todos los issues de NCATSTranslator/NameResolution
Issues similares
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 86/100
benchflow-ai/skillsbench#1090 ·
-
Missing unit tests for human-readable date/time formatters in utils/datetime.pyPosiblemente ocupada @prabhleen2317 la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
apache/iceberg-python#4387 ·
Los mantenedores suelen responder en 1 día
-
[BUG] Hermes MCP adapter drops cwd, extra passthrough keys and the SSE transport when writing config.yamlPosiblemente ocupada @Parth-Vasave la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
microsoft/apm#3749 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
backend bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
NVIDIA/numba-cuda-mlir#467 · 1 comentario ·
Los mantenedores suelen responder en 3 días