Conditional mapping with nested adapters fails for one type but works for another identical pattern
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 48/100
Línea de trabajo
Comienza con la configuración suministrada de InquiryResponseMapper.Register y reproduce después el mapeo mediante TypeAdapterConfig.Compile() y Mapper para ambas ramas de OneOf. Compara el mapeo condicional de PlaintextCard y EncryptedCard con sus adaptadores anidados registrados; se considera terminado cuando PlaintextCard se rellena mediante su adaptador sin romper la ruta funcional de EncryptedCard.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Conditional mapping with nested adapters fails for one type but works for another identical pattern
Summary
When using conditional mapping (3-parameter .Map() overload) with OneOf types, Mapster successfully applies nested adapters for EncryptedCard but fails to apply them for PlaintextCard, even though both use the exact same mapping pattern. The PlaintextCard property is set to null instead of being mapped through the registered adapter.
Environment
- Mapster Version: 7.4.0
- Mapster.Core Version: 1.2.1
- MapsterMapper Version: 1.0.2
- .NET Version: .NET 9.0
- Project Type: ASP.NET Core Web API with gRPC
Minimal Reproduction
Source Types
// OneOf discriminated union
[GenerateOneOf]
public partial class CardOf : OneOfBase<CardWithPlainTextPan, CardWithEncryptedPan>;
public record CardWithPlainTextPan(string Pan, string ExpiryYear, string ExpiryMonth);
public record CardWithEncryptedPan(
string EncryptedCardData,
string ExpiryYear,
string ExpiryMonth);
public record AccountUpdaterInquiryResponse(InquiryStatus Status, Maybe<CardOf> Card);
Destination Types (Protobuf Generated)
// From protobuf - simplified
public sealed partial class InquiryResponse
{
public Processing.Card.V2.Card PlaintextCard { get; set; }
public Processing.Card.V2.EncryptedCard EncryptedCard { get; set; }
public InquiryStatus Status { get; set; }
public enum AccountOneofCase { None, PlaintextCard, EncryptedCard }
}
public sealed partial class Card
{
public string Pan { get; set; }
public string ExpiryYear { get; set; }
public string ExpiryMonth { get; set; }
public string Cvc { get; set; } // Optional field
}
public sealed partial class EncryptedCard
{
public string JweCompactEncryptedData { get; set; }
public string ExpiryYear { get; set; }
public string ExpiryMonth { get; set; }
public EncryptedCardContentType EncryptedDataContentType { get; set; }
}
Mapper Configuration
public class InquiryResponseMapper : IRegister
{
public void Register(TypeAdapterConfig config)
{
// Nested adapter for PlaintextCard
config.NewConfig<CardWithPlainTextPan, Processing.Card.V2.Card>()
.Map(d => d.Pan, s => s.Pan)
.Map(d => d.ExpiryMonth, s => s.ExpiryMonth)
.Map(d => d.ExpiryYear, s => s.ExpiryYear)
.Ignore(d => d.Cvc);
// Nested adapter for EncryptedCard
config.NewConfig<CardWithEncryptedPan, Processing.Card.V2.EncryptedCard>()
.Map(d => d.JweCompactEncryptedData, s => s.EncryptedCardData)
.Map(d => d.EncryptedDataContentType,
s => Processing.Card.V2.EncryptedCardContentType.JsonCardNumberWithOptCvvCamelCase)
.Map(d => d.ExpiryYear, s => s.ExpiryYear)
.Map(d => d.ExpiryMonth, s => s.ExpiryMonth);
// Main mapping with conditional logic
config.NewConfig<AccountUpdaterInquiryResponse, InquiryResponse>()
.Map(d => d.PlaintextCard, s => s.Card.Value.AsT0, s => s.Card.HasValue && s.Card.Value.IsT0)
.Map(d => d.EncryptedCard, s => s.Card.Value.AsT1, s => s.Card.HasValue && s.Card.Value.IsT1)
.Map(d => d.Status, s => ConvertInquiryStatus(s.Status));
}
}
Test Configuration
var config = new TypeAdapterConfig();
config.Default.RequireDestinationMemberSource(value: true);
new InquiryResponseMapper().Register(config);
config.Compile();
var mapper = new Mapper(config);
Expected Behavior
Both PlaintextCard and EncryptedCard should be mapped through their respective nested adapters:
- When
Card.Value.IsT0is true,PlaintextCardshould be populated viaCardWithPlainTextPan -> Processing.Card.V2.Cardadapter - When
Card.Value.IsT1is true,EncryptedCardshould be populated viaCardWithEncryptedPan -> Processing.Card.V2.EncryptedCardadapter
Actual Behavior
- ✅
EncryptedCardworks correctly - nested adapter is applied, all fields mapped - ❌
PlaintextCardisnull- nested adapter is NOT applied, even though the condition evaluates totrue
Test Results
Passed: 18 tests for EncryptedCard mapping
Failed: 8 tests for PlaintextCard mapping (NullReferenceException on line accessing PlaintextCard.Pan)
What We've Tried
- Reordering configurations - Registering PlaintextCard adapter before EncryptedCard
- Different mapping approaches:
- Ternary operator:
.Map(d => d.PlaintextCard, s => s.Card.HasValue && s.Card.Value.IsT0 ? s.Card.Value.AsT0 : null) - AfterMapping callbacks
- Manual adapter invocation functions
- Ternary operator:
- Property mapping variations:
- Changed property order to match constructor
- Explicit mapping of Cvc to empty string instead of Ignore
- Type disambiguation - Added
using Card = Processing.Card.V2.Card;alias - ForType declarations - Explicitly declaring both adapters with
config.ForType<>()
None of these approaches resolved the issue, while EncryptedCard continues to work perfectly with the exact same pattern.
Key Observations
- The problem is asymmetric - identical mapping patterns behave differently
- The destination type name
Cardis very generic, whileEncryptedCardis more specific - Source types use OneOf discriminated unions from the OneOf NuGet package
- Destination types are protobuf-generated with oneof fields
- The nested adapter IS registered and CAN be used directly, but isn't invoked through conditional mapping
RequireDestinationMemberSource(true)is satisfied (no compilation errors about unmapped members)
Workaround Needed
Is there a recommended pattern for mapping through OneOf types with nested adapters that ensures consistent behavior? Or is this a bug that needs fixing?
Additional Context
This appears to be related to how Mapster resolves and applies nested adapters when the source value comes from a conditional expression involving discriminated union types. The fact that one type works and another doesn't suggests there may be type resolution or caching issues specific to certain type names or structures.
- Lenguaje dominante
- C#
- Estrellas
- 5.2k
- Forks
- 411
- Merge medio
- 3 d 4 h
- PR fusionados (30 d)
- 3
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de MapsterMapper/Mapster
-
.NET MatrixAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
MapsterMapper/Mapster#1003 ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 58/100
MapsterMapper/Mapster#1024 · 1 comentario ·
-
[Mapster Tool] Add support for global:: to disambiguate type names in generated mappersPosiblemente ocupada @DocSvartz la tomó hace 3 días. Abiertoimprovement
Dificultad 3/5 1-2 días Aptitud para principiantes 65/100
MapsterMapper/Mapster#1020 · 5 comentarios ·
-
Mapster.Tool - PropertySettingBuilder.Map(member, mapFunc, targetPropertyName) method is not working as expected!Posiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 68/100
MapsterMapper/Mapster#1017 · 6 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 57/100
MapsterMapper/Mapster#1007 · 5 comentarios ·
Todos los issues de MapsterMapper/Mapster
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
bug priority: P2
Dificultad 1/5 Menos de una hora Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
IridiumIO/CompactGUI#699 ·
Los mantenedores suelen responder en 3 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
bitfoundation/bitplatform#14070 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 73/100
Los mantenedores suelen responder en 1 día