Characterize cancellation notification and sequential-signing consistency

Abierto
#9,084 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
php
Área
backend, testing

Línea de trabajo

Start with tests/integration/features/sign/cancel.feature and sequential_signing.feature; inspect how the existing PHPUnit integration environment persists signing requests and how the Behat scenarios observe notifications. Reproduce the controlled removal failure and the same-order signer flow described in the issue, then run the relevant integration tests. Done means the tests confirm no cancellation notification or false success after failed removal, and that C is activated and notified once only after A signs.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

backend php

Goal

Verify that cancellation and sequential-signing notifications correspond to successful persisted state changes.

Test approach

Reuse tests/integration/features/sign/cancel.feature and sequential_signing.feature.

Persistence failure

Using PHPUnit integration with the existing Nextcloud test environment:

  1. Persist an active unsigned signing request.
  2. Introduce one controlled failure at the persistence boundary for its removal.
  3. Execute the cancellation operation.
  4. Reload the persisted state and observe cancellation events.

Expected:

  • The signer remains persisted.
  • No cancellation notification is emitted for an unsuccessful removal.
  • The operation does not silently report success.
  • Unrelated state is unchanged.

Use real persistence wherever possible and the minimum substitution necessary to reproduce the failure.

Sequential flow

Using Behat:

  1. Create signers A and B at the same first signing order, with C at the next order.
  2. Before anyone signs, remove pending signer B.
  3. Verify that A remains active and C is not prematurely activated or notified.
  4. Complete A's signature.
  5. Verify that C becomes eligible and receives the expected activation notification once.

This must not depend on modifying signer-removal permissions after a document becomes partially signed.

Boundaries

No generic failure-injection framework, broad notification refactor or new delivery mechanism.

Result and handoff

A passing test may be merged normally.

For a confirmed failure, preserve the test commit and sanitized execution evidence without merging a failing test. Request maintainer review to determine the smallest appropriate fix.

If the required correction extends beyond this investigation, establish a traceable follow-up and carry the same regression test into the corrective work.

Lenguaje dominante
PHP
Estrellas
844
Forks
176
Merge medio
14 h 3 min
PR fusionados (30 d)
344

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de LibreSign/libresign

Todos los issues de LibreSign/libresign

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.