An unhandled rejection takes the process down with no record

Cerrado
  • ¿Algo no está bien?
#344 2 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 4 días

@notoflagosola-wq ya está trabajando en esto.

Desde el 16/10/2026.

  • #467 de @sparkysolutions10-pixel — abierto
  • #472 de @notoflagosola-wq — abierto

Evaluación

Este issue todavía no se ha evaluado.

Descripción

area:reliability difficulty:easy help wanted points:100 Stellar Wave
Background

There is no process.on('unhandledRejection') or process.on('uncaughtException')
handler. Node's default for an unhandled rejection is to terminate, so a single
missed .catch() anywhere — in an ingester, a job, a fanout timer — kills the
whole service, and the only evidence is whatever the platform happened to capture
on stderr.

This service is full of background work that is not awaited by anyone:
restartIngester calls fn().catch(...), the retention fallback runs inside a
setInterval, and fanout.ts sends from timer callbacks.

What to build
  • Handlers for unhandledRejection and uncaughtException that log the error
    with its stack through the structured logger, then exit non-zero so the
    platform restarts cleanly.
  • Do not swallow and continue — a process in an unknown state serving prices
    is worse than one that restarts.
  • A counter metric so repeated crashes are visible after the fact.
  • Make sure the graceful shutdown from L164 is not re-entered from this path.
Acceptance criteria
  • Both handlers are installed early in startup
  • The full error and stack are logged before exit
  • The process exits non-zero
  • The handler does not attempt a normal graceful drain
  • A test asserts the handler logs and exits rather than continuing

Drips Wave · Complexity: Easy · 100 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lenguaje dominante
TypeScript
Estrellas
4
Forks
71
Merge medio
3 d 22 h
PR fusionados (30 d)
142

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Divinity-Labs/Lens

Todos los issues de Divinity-Labs/Lens

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.