Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Dead websocket connections are never reaped

Cerrado
  • ¿Algo no está bien?
#336 2 comentarios 0 reacciones 1 asignado Ver en GitHub

Los mantenedores suelen responder en 3 días

@samkelly-dev ya está trabajando en esto.

Desde el 16/10/2026.

  • #384 de @samkelly-dev — abierto
  • #464 de @sparkysolutions10-pixel — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
62/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
prometheus, redis, typescript
Área
backend, observability

Línea de trabajo

Start in src/api/websocket.ts and src/ws/fanout.ts, where clients and pairClients are registered and removed, and trace what removal currently leaves behind. Add a configurable ping interval and missed-pong limit, close and unregister silent clients, and export a connected-clients gauge through prom-client. Done when a vitest test in src/tests shows both maps emptied after removal and a slow but responding client stays connected. Run it with npx vitest run, not jest.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:websocket difficulty:easy help wanted points:100 Stellar Wave
Background

Neither src/api/websocket.ts nor src/ws/fanout.ts contains any ping, pong or
heartbeat handling. A TCP connection that dies without a close frame — a laptop
lid closing, a phone losing signal, a NAT mapping expiring — stays in the
clients map indefinitely. The server keeps serialising and queueing updates
for a peer that is gone.

fanout.ts keeps two maps keyed by client id, so every such ghost also holds a
subscription entry that makes every fanout loop slightly more expensive, forever.

What to build
  • A periodic ping to every connected client.
  • Track pong responses; a client that misses a configurable number of
    consecutive pings is closed and unregistered.
  • Make sure unregistering cleans up both clients and pairClients, so no
    subscription entry is orphaned.
  • A gauge of currently connected clients, so a leak is visible on the dashboard.
Acceptance criteria
  • Clients are pinged on a configurable interval
  • A client that stops responding is closed and removed
  • Both internal maps are cleaned up on removal, asserted by a test
  • A connected-clients gauge is exported
  • A normal client with a slow but live connection is not disconnected

Drips Wave · Complexity: Easy · 100 points

Repo: Divinity-Labs/Lens. Node + TypeScript, Fastify, Prisma on Postgres,
Redis for queues, Prometheus via prom-client.

Run the tests: npm test. The tests are vitest, not jest. Running jest
against this repo reports "66 suites, 0 tests" and means nothing. A single file
is npx vitest run src/__tests__/yourfile.test.ts.

Load test (prices) is already failing on main and has been for some
time. It is not your PR that broke it. Every other check should be green.

This service prices real assets on Stellar mainnet. A number that is wrong
is worse than a number that is missing, because a caller cannot tell the
difference. Prefer failing loudly over returning a plausible value.

Never elide an address, a contract id or a key in code, a comment or a test
fixture. A previous batch wrote a shortened contract id in an issue text and
five contributors invented plausible-looking ids to fill the gap. Write the
whole thing or do not write it at all.

The house pattern for an outbound deadline already exists — see
src/alerts/delivery.ts, which passes signal: AbortSignal.timeout(10_000) to
fetch. Where an issue below asks for a timeout, copy that, do not invent a
second convention.

Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk

Lenguaje dominante
TypeScript
Estrellas
4
Forks
71
Merge medio
3 d 6 h
PR fusionados (30 d)
144

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Divinity-Labs/Lens

Todos los issues de Divinity-Labs/Lens

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.